Implement performant instrumentation engine #1257
Closed
MarcoRossignoli
started this conversation in
Ideas
Replies: 2 comments 1 reply
-
|
I think we can explore folding, since a single C# line can lead to multiple different instructions that all share they same line numbers. I haven't looked at the instrumentation code in a while but it should be pretty straightforward to perform folding |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Closing this discussion since it’s no longer relevant to the current state of the project. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Today we have some perf issues https://github.com/coverlet-coverage/coverlet/issues?q=is%3Aopen+is%3Aissue+label%3Atenet-performance
But the main one is how the instrumentation is done. We rely heavily on sequences point and we're emitting a lot of code that can lead to a very poor performance during testing(for instance in code with tight loops)
We should try to implement a better strategy or try to fold contiguous hit points when possible.
cc: @daveMueller @petli @tonerdo
Beta Was this translation helpful? Give feedback.
All reactions