Skip to content

Duplicate streams to "shouldShare" channels #14

@coord-e

Description

@coord-e

You can't have more than two connections to the "shouldShare" channel.

https://github.com/syuilo/misskey/blob/572e475b394aab0fd752783da8648b4f096653fd/src/server/api/stream/index.ts#L220-L222

Quoting the current behavior from the documentation:

Note that currently it is not possible to have multiple connections to the main stream from the same client. If you try to do so, the Future returned by this method will not complete.

This is an inconvenient and confusing behavior for a library. It is expected that the implementation will make the connection the first time and reuse it for the second and subsequent connections.

Unresolved questions

  • Where to implement:
    • misskey-websocket: Almost looks good, but feel like the obligation (to duplicate the connection) is misplaced
    • misskey-util: We may need to stop using the extension trait, which is undesirable

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions