-
Notifications
You must be signed in to change notification settings - Fork 347
Expand file tree
/
Copy pathcompress_test.go
More file actions
311 lines (254 loc) · 8.49 KB
/
compress_test.go
File metadata and controls
311 lines (254 loc) · 8.49 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
//go:build !js
package websocket
import (
"bufio"
"bytes"
"compress/flate"
"context"
"io"
"net"
"strings"
"testing"
"time"
"github.com/coder/websocket/internal/test/assert"
"github.com/coder/websocket/internal/test/xrand"
)
func Test_slidingWindow(t *testing.T) {
t.Parallel()
const testCount = 99
const maxWindow = 99999
for range testCount {
t.Run("", func(t *testing.T) {
t.Parallel()
input := xrand.String(maxWindow)
windowLength := xrand.Int(maxWindow)
var sw slidingWindow
sw.init(windowLength)
sw.write([]byte(input))
assert.Equal(t, "window length", windowLength, cap(sw.buf))
if !strings.HasSuffix(input, string(sw.buf)) {
t.Fatalf("r.buf is not a suffix of input: %q and %q", input, sw.buf)
}
})
}
}
func BenchmarkFlateWriter(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
w, _ := flate.NewWriter(io.Discard, flate.BestSpeed)
// We have to write a byte to get the writer to allocate to its full extent.
w.Write([]byte{'a'})
w.Flush()
}
}
func BenchmarkFlateReader(b *testing.B) {
b.ReportAllocs()
var buf bytes.Buffer
w, _ := flate.NewWriter(&buf, flate.BestSpeed)
w.Write([]byte{'a'})
w.Flush()
for i := 0; i < b.N; i++ {
r := flate.NewReader(bytes.NewReader(buf.Bytes()))
io.ReadAll(r)
}
}
// TestWriteSingleFrameCompressed verifies that Conn.Write sends compressed
// messages in a single frame instead of multiple frames, and that messages
// below the flateThreshold are sent uncompressed.
// This is a regression test for https://github.com/coder/websocket/issues/435
func TestWriteSingleFrameCompressed(t *testing.T) {
t.Parallel()
var (
flateThreshold = 64
largeMsg = []byte(strings.Repeat("hello world ", 100))
smallMsg = []byte("small message")
)
testCases := []struct {
name string
mode CompressionMode
msg []byte
wantRsv1 bool // true = compressed, false = uncompressed
}{
{"ContextTakeover/AboveThreshold", CompressionContextTakeover, largeMsg, true},
{"NoContextTakeover/AboveThreshold", CompressionNoContextTakeover, largeMsg, true},
{"ContextTakeover/BelowThreshold", CompressionContextTakeover, smallMsg, false},
{"NoContextTakeover/BelowThreshold", CompressionNoContextTakeover, smallMsg, false},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
clientConn, serverConn := net.Pipe()
defer clientConn.Close()
defer serverConn.Close()
c := newConn(connConfig{
rwc: clientConn,
client: true,
copts: tc.mode.opts(),
flateThreshold: flateThreshold,
br: bufio.NewReader(clientConn),
bw: bufio.NewWriterSize(clientConn, 4096),
})
ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*100)
defer cancel()
writeDone := make(chan error, 1)
go func() {
writeDone <- c.Write(ctx, MessageText, tc.msg)
}()
reader := bufio.NewReader(serverConn)
readBuf := make([]byte, 8)
h, err := readFrameHeader(reader, readBuf)
assert.Success(t, err)
_, err = io.CopyN(io.Discard, reader, h.payloadLength)
assert.Success(t, err)
assert.Equal(t, "opcode", opText, h.opcode)
assert.Equal(t, "rsv1 (compressed)", tc.wantRsv1, h.rsv1)
assert.Equal(t, "fin", true, h.fin)
err = <-writeDone
assert.Success(t, err)
})
}
}
// TestWriteThenWriterContextTakeover verifies that using Conn.Write followed by
// Conn.Writer works correctly with context takeover enabled. This tests that
// the flateWriter destination is properly restored after Conn.Write redirects
// it to a temporary buffer.
func TestWriteThenWriterContextTakeover(t *testing.T) {
t.Parallel()
clientConn, serverConn := net.Pipe()
defer clientConn.Close()
defer serverConn.Close()
client := newConn(connConfig{
rwc: clientConn,
client: true,
copts: CompressionContextTakeover.opts(),
flateThreshold: 64,
br: bufio.NewReader(clientConn),
bw: bufio.NewWriterSize(clientConn, 4096),
})
server := newConn(connConfig{
rwc: serverConn,
client: false,
copts: CompressionContextTakeover.opts(),
flateThreshold: 64,
br: bufio.NewReader(serverConn),
bw: bufio.NewWriterSize(serverConn, 4096),
})
ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*500)
defer cancel()
msg1 := []byte(strings.Repeat("first message ", 100))
msg2 := []byte(strings.Repeat("second message ", 100))
type readResult struct {
typ MessageType
p []byte
err error
}
readCh := make(chan readResult, 3)
go func() {
for range 3 {
typ, p, err := server.Read(ctx)
readCh <- readResult{typ, p, err}
}
}()
// We want to verify mixing `Write` and `Writer` usages still work.
//
// To this end, we call them in this order:
// - `Write`
// - `Writer`
// - `Write`
//
// This verifies that it works for a `Write` followed by a `Writer`
// as well as a `Writer` followed by a `Write`.
// 1. `Write` API
err := client.Write(ctx, MessageText, msg1)
assert.Success(t, err)
r := <-readCh
assert.Success(t, r.err)
assert.Equal(t, "Write type", MessageText, r.typ)
assert.Equal(t, "Write content", string(msg1), string(r.p))
// 2. `Writer` API
w, err := client.Writer(ctx, MessageBinary)
assert.Success(t, err)
_, err = w.Write(msg2)
assert.Success(t, err)
assert.Success(t, w.Close())
r = <-readCh
assert.Success(t, r.err)
assert.Equal(t, "Writer type", MessageBinary, r.typ)
assert.Equal(t, "Writer content", string(msg2), string(r.p))
// 3. `Write` API again
err = client.Write(ctx, MessageText, msg1)
assert.Success(t, err)
r = <-readCh
assert.Success(t, r.err)
assert.Equal(t, "Write type", MessageText, r.typ)
assert.Equal(t, "Write content", string(msg1), string(r.p))
}
// TestCompressionDictionaryPreserved verifies that context takeover mode
// preserves the compression dictionary across Conn.Write calls, resulting
// in better compression for consecutive similar messages.
func TestCompressionDictionaryPreserved(t *testing.T) {
t.Parallel()
msg := []byte(strings.Repeat(`{"type":"event","data":"value"}`, 50))
takeoverClient, takeoverServer := net.Pipe()
defer takeoverClient.Close()
defer takeoverServer.Close()
withTakeover := newConn(connConfig{
rwc: takeoverClient,
client: true,
copts: CompressionContextTakeover.opts(),
flateThreshold: 64,
br: bufio.NewReader(takeoverClient),
bw: bufio.NewWriterSize(takeoverClient, 4096),
})
noTakeoverClient, noTakeoverServer := net.Pipe()
defer noTakeoverClient.Close()
defer noTakeoverServer.Close()
withoutTakeover := newConn(connConfig{
rwc: noTakeoverClient,
client: true,
copts: CompressionNoContextTakeover.opts(),
flateThreshold: 64,
br: bufio.NewReader(noTakeoverClient),
bw: bufio.NewWriterSize(noTakeoverClient, 4096),
})
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
// Capture compressed sizes for both modes
var withTakeoverSizes, withoutTakeoverSizes []int64
reader1 := bufio.NewReader(takeoverServer)
reader2 := bufio.NewReader(noTakeoverServer)
readBuf := make([]byte, 8)
// Send 3 identical messages each
for range 3 {
// With context takeover
writeDone1 := make(chan error, 1)
go func() {
writeDone1 <- withTakeover.Write(ctx, MessageText, msg)
}()
h1, err := readFrameHeader(reader1, readBuf)
assert.Success(t, err)
_, err = io.CopyN(io.Discard, reader1, h1.payloadLength)
assert.Success(t, err)
withTakeoverSizes = append(withTakeoverSizes, h1.payloadLength)
assert.Success(t, <-writeDone1)
// Without context takeover
writeDone2 := make(chan error, 1)
go func() {
writeDone2 <- withoutTakeover.Write(ctx, MessageText, msg)
}()
h2, err := readFrameHeader(reader2, readBuf)
assert.Success(t, err)
_, err = io.CopyN(io.Discard, reader2, h2.payloadLength)
assert.Success(t, err)
withoutTakeoverSizes = append(withoutTakeoverSizes, h2.payloadLength)
assert.Success(t, <-writeDone2)
}
// With context takeover, the 2nd and 3rd messages should be smaller than
// without context takeover (dictionary helps compress repeated patterns).
// The first message will be similar size for both modes since there's no
// prior dictionary. But subsequent messages benefit from context takeover.
if withTakeoverSizes[2] >= withoutTakeoverSizes[2] {
t.Errorf("context takeover should compress better: with=%d, without=%d",
withTakeoverSizes[2], withoutTakeoverSizes[2])
}
}