[BUG] Not detecting reports even though they contain `junit` in the name

[joseph-sentry]

In this PR, it was necessary to specify the files using a glob pattern to detect the files for the browser unit tests. before after

since those files contain junit in the name, they should be automatically detected, so something is wrong with the detection in the CLI, it's possible that it's incapable of detecting reports nested in deeper directories.

[ssbarnea]

I spent few hours trying to get this action to use wildcards with any of directory, file and files and I was not able to find even one case where this worked.

I need to report ./tox/**/junit.xml files, so if anyone can disclose how to do this it would be awesome. A search on https://sourcegraph.com/search?q=path:.github/workflows+codecov/test-results-action%40v1+%22files:+./%22&patternType=keyword&sm=0 showed that nobody ever used whildcards with this action (at least un public repositories).

[dvins]

Ditto. I'm several hours in and discovering the same issue when using with a monorepo, we even make it easy and pre-gather all the results int a single folder, and it's still not working. Ridiculous.

[dvins]

Through some shell magic I was able to rejigger our GitHub Workflow and get this to work.

My monorepo test workflow already gathers all the relevant test coverage and result files from each of our projects into a single location, namely so we can merge coverage. I ultimately added a step to enumerate the list of junit.xml files into a variable, and then explicitly pass that list into the Codecov Test Results action via the files attribute:

steps:
  - name: Collect Test Coverage & Results
    run: |
      pnpm turbo coverage:gather
      pnpm turbo coverage:merge
      pnpm turbo coverage:report
  
  - name: "Generate Test Results File List (See: https://github.com/codecov/test-results-action/issues/110)"
    id: test-results
    run: |
      FILES=$(find ./coverage/raw/junit -type f -name "*.junit.xml" | paste -sd "," -)
      echo "file_list=$FILES" >> $GITHUB_OUTPUT
      echo "file_list=$FILES"
  
  - name: Upload Test Results to Sentry Codecov
    if: ${{ !cancelled() }}
    uses: codecov/test-results-action@v1
    timeout-minutes: 10
    with:
      directory: coverage/raw/junit
      files: ${{ steps.test-results.outputs.file_list }}
      flags: unit
      token: ${{ secrets.CODECOV_TOKEN }}

Note I still had to add the directory attribute, because otherwise the Codecov Test Results action still scavenges files from everywhere else, so you end up with duplicates.

Even better, the action when it executes emits a cryptic warning in the logs, "Some files being explicitly added are found in the list of excluded files for upload. We are still going to search for the explicitly added files." Makes. No. Sense.

Anyhow, after all this effort, have to say, the Tests tab in the Codecov UI is quite underwhelming. It doesn't even rollup by test suite let alone module and folder!

Here's a link to the Gist: https://gist.github.com/dvins/ef9f79b849ed0767e90f01cbc160b403

[joseph-sentry]

I added a docs page here to clarify the current behaviour of the arguments, please let me know if you have any more questions:
https://docs.codecov.com/docs/file-search

[dvins]

@joseph-sentry That documentation pertains to the CLI, which the action wraps. But how does one configure those parameters via the action in a GitHub Workflow? Also, when will this and other bugs be fixed?

[joseph-sentry]

just updated the doc to reflect the equivalent action arguments for each example, above each example is a button that will let you switch between the CLI and Action version: