NATSSync uses Net:HTTP instead of RestClient

The latter has not had updates in several years where as `Net::HTTP` is
a core ruby library.

Author: aramprice

src/Gemfile.lock

@@ -54,7 +54,6 @@ PATH
       json
       logging
       openssl
-      rest-client
       rufus-scheduler
 
 PATH
@@ -151,7 +150,6 @@ GEM
     docile (1.4.1)
     dogapi (1.45.0)
       multi_json
-    domain_name (0.6.20240107)
     drb (2.2.1)
     et-orbi (1.2.11)
       tzinfo
@@ -167,9 +165,6 @@ GEM
       et-orbi (~> 1, >= 1.2.11)
       raabro (~> 1.4)
     hashdiff (1.1.2)
-    http-accept (1.7.0)
-    http-cookie (1.0.7)
-      domain_name (~> 0.5)
     httpclient (2.8.3)
     i18n (1.14.6)
       concurrent-ruby (~> 1.0)
@@ -186,10 +181,6 @@ GEM
     membrane (1.1.0)
     method_source (1.1.0)
     metrics (0.12.1)
-    mime-types (3.6.0)
-      logger
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2024.1105)
     mini_portile2 (2.8.8)
     minitar (1.0.2)
     minitest (5.25.1)
@@ -204,7 +195,6 @@ GEM
       timeout
     net-smtp (0.5.0)
       net-protocol
-    netrc (0.11.0)
     nio4r (2.7.4)
     openssl (3.2.0)
     ostruct (0.6.1)
@@ -244,11 +234,6 @@ GEM
     rainbow (3.1.1)
     rake (13.2.1)
     regexp_parser (2.9.2)
-    rest-client (2.1.0)
-      http-accept (>= 1.7.0, < 2.0)
-      http-cookie (>= 1.0.2, < 2.0)
-      mime-types (>= 1.16, < 4.0)
-      netrc (~> 0.8)
     rexml (3.3.9)
     riemann-client (1.2.1)
       beefcake (>= 1.0.0)

src/bosh-nats-sync/bosh-nats-sync.gemspec

@@ -26,7 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'logging'
   spec.add_dependency 'openssl'
   spec.add_dependency 'rufus-scheduler'
-  spec.add_dependency 'rest-client'
 
   spec.add_development_dependency 'rack-test'
   spec.add_development_dependency 'rspec'

src/bosh-nats-sync/lib/nats_sync/users_sync.rb

@@ -1,10 +1,11 @@
-require 'rest-client'
 require 'base64'
 require 'nats_sync/nats_auth_config'
 require 'open3'
 
 module NATSSync
   class UsersSync
+    HTTP_SUCCESS = "200"
+
     def initialize(nats_config_file_path, bosh_config, nats_server_executable, nats_server_pid_file)
       @nats_config_file_path = nats_config_file_path
       @bosh_config = bosh_config
@@ -42,15 +43,13 @@ def execute_users_sync
     end
 
     def self.reload_nats_server_config(nats_server_executable, nats_server_pid_file)
-      output, status = Open3.capture2e("#{nats_server_executable} --signal reload=#{nats_server_pid_file}")
+      nats_command = "#{nats_server_executable} --signal reload=#{nats_server_pid_file}"
+
+      output, status = Open3.capture2e(nats_command)
 
-      # rubocop:disable Style/GuardClause
-      # rubocop:disable Layout/LineLength
       unless status.success?
-        raise("Cannot execute: #{nats_server_executable} --signal reload=#{nats_server_pid_file}, Status Code: #{status} \nError: #{output}")
+        raise("Cannot execute: #{nats_command}, Status Code: #{status}\nError: #{output}")
       end
-      # rubocop:enable Style/GuardClause
-      # rubocop:enable Layout/LineLength
     end
 
     private
@@ -72,28 +71,33 @@ def nats_file_hash
       Digest::MD5.file(@nats_config_file_path).hexdigest
     end
 
-    def call_bosh_api(endpoint)
-      auth_header = create_authentication_header
-      NATSSync.logger.debug 'auth_header is empty, next REST call could fail' if auth_header.nil? || auth_header.empty?
-      response = RestClient::Request.execute(
-        url: @bosh_config['url'] + endpoint,
-        method: :get,
-        headers: { 'Authorization' => auth_header },
-        verify_ssl: false,
-      )
+    def parsed_uri_for(api_path:)
+      URI.parse("#{@bosh_config['url']}#{api_path}")
+    end
+
+    def bosh_api_response_body(api_path, auth: true)
+      parsed_uri = parsed_uri_for(api_path: api_path)
+
+      response =
+        Net::HTTP.new(parsed_uri.host, parsed_uri.port).tap do |http|
+          http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+        end.get(parsed_uri.request_uri, build_headers(auth: auth))
+
       NATSSync.logger.debug(response.inspect)
-      raise("Cannot access: #{endpoint}, Status Code: #{response.code}, #{response.body}") unless response.code == 200
+      unless response.code == HTTP_SUCCESS
+        raise("Cannot access: #{api_path}, Status Code: #{response.code}, #{response.body}")
+      end
 
       response.body
     end
 
     def query_all_deployments
-      deployments_json = JSON.parse(call_bosh_api('/deployments'))
+      deployments_json = JSON.parse(bosh_api_response_body('/deployments'))
       deployments_json.map { |deployment| deployment['name'] }
     end
 
     def get_vms_by_deployment(deployment)
-      JSON.parse(call_bosh_api("/deployments/#{deployment}/vms"))
+      JSON.parse(bosh_api_response_body("/deployments/#{deployment}/vms"))
     end
 
     def query_all_running_vms
@@ -103,27 +107,21 @@ def query_all_running_vms
       vms
     end
 
-    def call_bosh_api_no_auth(endpoint)
-      response = RestClient::Request.execute(
-        url: @bosh_config['url'] + endpoint,
-        method: :get,
-        verify_ssl: false,
-      )
-      NATSSync.logger.debug(response.inspect)
-      raise("Cannot access: #{endpoint}, Status Code: #{response.code}, #{response.body}") unless response.code == 200
-
-      response.body
-    end
-
     def info
       return @director_info if @director_info
-      body = call_bosh_api_no_auth('/info')
 
-      @director_info = JSON.parse(body)
+      @director_info = JSON.parse(bosh_api_response_body('/info', auth: false))
     end
 
-    def create_authentication_header
-      NATSSync::AuthProvider.new(info, @bosh_config).auth_header
+    def build_headers(auth: true)
+      if auth
+        auth_header = "#{NATSSync::AuthProvider.new(info, @bosh_config).auth_header}"
+        NATSSync.logger.debug 'auth_header is empty, next REST call could fail' if auth_header.empty?
+
+        { 'Authorization' => auth_header }
+      else
+        {}
+      end
     end
 
     def write_nats_config_file(vms, director_subject, hm_subject)

src/bosh-nats-sync/spec/nats_sync/users_sync_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 require 'nats_sync/users_sync'
-require 'rest-client'
 
 module NATSSync
   describe UsersSync do

src/spec/spec_helper.rb

@@ -10,7 +10,6 @@
 require 'tmpdir'
 require 'tempfile'
 require 'yaml'
-require 'restclient'
 
 require 'bosh/director'
 require 'nats/client'