Merge pull request #48 from anthonysterling/fix/issue-46

Nest payload for forwarding_url page rule action in value block

Author: IcyApril

src/Configurations/PageRulesActions.php

@@ -132,9 +132,11 @@ public function setForwardingURL(int $statusCode, string $forwardingUrl)
             throw new ConfigurationsException('Status Codes can only be 301 or 302.');
         }
 
-        $this->addConfigurationOption('forwarding_url', [
-            'status_code' => $statusCode,
-            'url' => $forwardingUrl,
+        $this->addConfigurationOption("forwarding_url", [
+            'value' => [
+                'status_code' => $statusCode,
+                'url' => $forwardingUrl,
+            ],
         ]);
     }
 
@@ -299,9 +301,19 @@ public function getArray(): array
 
     private function addConfigurationOption(string $setting, array $configuration)
     {
+        /**
+         * Transforms an, optionally nested, array in to a collection of
+         * stdClass objects.
+         *
+         * @var array $array
+         */
+        $getArrayAsObject = function (array $array) {
+            return json_decode(json_encode($array));
+        };
+
         $configuration['id'] = $setting;
 
-        $this->configs[] = (object) $configuration;
+        array_push($this->configs, $getArrayAsObject($configuration));
     }
 
     private function getBoolAsOnOrOff(bool $value): string

tests/Configurations/PageRulesActionTest.php

@@ -0,0 +1,21 @@
+<?php
+use Cloudflare\API\Configurations\PageRulesActions;
+
+class PageRulesActionTest extends TestCase
+{
+    public function testForwardingURLConfigurationIsApplied()
+    {
+        $identifier = 'forwarding_url';
+        $statusCode = 301;
+        $forwardingURL = 'https://www.example.org/';
+
+        $actions = new PageRulesActions();
+        $actions->setForwardingURL($statusCode, $forwardingURL);
+        $configuration = $actions->getArray();
+
+        $this->assertCount(1, $configuration);
+        $this->assertEquals($identifier, $configuration[0]->id);
+        $this->assertEquals($statusCode, $configuration[0]->value->status_code);
+        $this->assertEquals($forwardingURL, $configuration[0]->value->url);
+    }
+}