Skip to content

Commit a636fc9

Browse files
committed
Bugfixing...
1 parent 4fc5e58 commit a636fc9

File tree

6 files changed

+19
-23
lines changed

6 files changed

+19
-23
lines changed

res/layout-sw600dp-land/player_fragment.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160

161161
</LinearLayout>
162162

163-
<fragment android:name="de.qspool.clementineremote.ui.fragments.PlaylistFragment"
163+
<FrameLayout
164164
android:id="@+id/playlist_fragment"
165165
android:layout_weight="1"
166166
android:layout_width="match_parent"

src/de/qspool/clementineremote/backend/player/MyLibrary.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,15 @@ public class MyLibrary extends
6363

6464
public MyLibrary(Context context) {
6565
mContext = context;
66+
67+
if (databaseExists()) {
68+
openDatabase();
69+
boolean dbOk = db.isDatabaseIntegrityOk();
70+
closeDatabase();
71+
72+
if (!dbOk)
73+
getLibraryDb().delete();
74+
}
6675
}
6776

6877
public void addOnLibrarySelectFinishedListener(

src/de/qspool/clementineremote/ui/MainActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,8 @@ void disconnect() {
340340
void MessageFromClementine(ClementineMessage clementineMessage) {
341341
// Update the Player Fragment
342342
if (mFragments.get(mCurrentFragment) != null &&
343-
mFragments.get(mCurrentFragment).isVisible()) {
343+
mFragments.get(mCurrentFragment).isVisible() &&
344+
mFragments.get(mCurrentFragment).isAdded() ) {
344345
mFragments.get(mCurrentFragment).MessageFromClementine(clementineMessage);
345346
}
346347
}

src/de/qspool/clementineremote/ui/fragments/PlayerFragment.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public void onCreate(Bundle savedInstanceState) {
104104

105105
@Override
106106
public View onCreateView(LayoutInflater inflater, ViewGroup container,
107-
Bundle savedInstanceState) {
107+
Bundle savedInstanceState) {
108108
View view = inflater.inflate(R.layout.player_fragment,
109109
container, false);
110110

@@ -150,7 +150,10 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
150150
mPdDownloadLyrics.setMessage(getString(R.string.player_download_lyrics));
151151
mPdDownloadLyrics.setCancelable(true);
152152

153-
mPlaylistSongs = (PlaylistFragment) getFragmentManager().findFragmentById(R.id.playlist_fragment);
153+
if (view.findViewById(R.id.playlist_fragment) != null) {
154+
mPlaylistSongs = new PlaylistFragment();
155+
getFragmentManager().beginTransaction().replace(R.id.playlist_fragment, mPlaylistSongs).commit();
156+
}
154157

155158
// Initialize interface
156159
updateTrackMetadata();
@@ -181,14 +184,6 @@ public void onResume() {
181184
updateTrackMetadata();
182185
}
183186

184-
@Override
185-
public void onDestroyView() {
186-
super.onDestroyView();
187-
188-
if (mPlaylistSongs != null)
189-
getFragmentManager().beginTransaction().remove(mPlaylistSongs).commit();
190-
}
191-
192187
@Override
193188
public boolean onOptionsItemSelected(MenuItem item) {
194189
switch (item.getItemId())

src/de/qspool/clementineremote/ui/fragments/PlaylistFragment.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
145145
@Override
146146
public void onItemSelected(AdapterView<?> parent, View view,
147147
int position, long id) {
148-
setId(App.mClementine.getPlaylists().valueAt(position).getId());
148+
mId = App.mClementine.getPlaylists().valueAt(position).getId();
149149
updateSongList();
150150
}
151151

@@ -244,15 +244,6 @@ public boolean onContextItemSelected(android.view.MenuItem item) {
244244
}
245245
}
246246

247-
/**
248-
* Set the playlist id
249-
* @param id The playlist id, from which the songs are displayed
250-
*/
251-
public void setId(int id) {
252-
mId = id;
253-
mData = new LinkedList<MySong>(App.mClementine.getPlaylists().get(mId).getPlaylistSongs());
254-
}
255-
256247
public int getPlaylistId() {
257248
return mId;
258249
}

src/de/qspool/clementineremote/ui/fragments/SongInfoFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ private void zoomImageFromThumb(final View thumbView) {
259259
}
260260

261261
// If we don't have an image, do not zoom!
262-
if (mCurrentSong.getArt() == null)
262+
if (mCurrentSong == null || mCurrentSong.getArt() == null)
263263
return;
264264

265265
// Load the high-resolution "zoomed-in" image.

0 commit comments

Comments
 (0)