Skip to content
This repository was archived by the owner on Nov 21, 2019. It is now read-only.
This repository was archived by the owner on Nov 21, 2019. It is now read-only.

Withdraw checks possible enhancement #46

@magooster

Description

@magooster

Within the Mixer contracts Withdraw function the signature is checked for validity, including checking for the existence of the tag, then the 'tag' is added to ensure the same signer doesn't attempt to withdraw again.

Would this not be more readable if this were split into two checks, one where we require the signature tag not to already exist and the second to validate the signature.

require (AddTag)
require (SignatureValid)

The AddTag function would check for the existence of the tag, and return false if tag already exists or add and return true if it doesn't. This would also be consistent with the AddParticipant logic in the Deposit function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions