maybe gpio_defines_check could check that the constants are correct too.

[kassemmkk]

Originally created by d-m-bailey on 2022-11-21T17:18:49Z

@a-omla
Older versions of user_defines.v had the wrong constants defined.

$ diff slot-021/verilog/rtl/user_defines.v caravel_user_project/verilog/rtl/user_defines.v 
24,25c29,30
< `define GPIO_MODE_MGMT_STD_INPUT_PULLDOWN  13'h0803
< `define GPIO_MODE_MGMT_STD_INPUT_PULLUP    13'h0c03
---
> `define GPIO_MODE_MGMT_STD_INPUT_PULLDOWN  13'h0c01
> `define GPIO_MODE_MGMT_STD_INPUT_PULLUP    13'h0801
31,32c36,37
< `define GPIO_MODE_USER_STD_INPUT_PULLDOWN  13'h0802
< `define GPIO_MODE_USER_STD_INPUT_PULLUP    13'h0c02
---
> `define GPIO_MODE_USER_STD_INPUT_PULLDOWN  13'h0c00
> `define GPIO_MODE_USER_STD_INPUT_PULLUP    13'h0800

Would it be possible to add a check for the correct (newer) constants?

[kassemmkk]

Comment originally by a-omla on 2022-11-25T12:47:04Z

@d-m-bailey I will bring it up and see what we can do, the current check should cover that, I believe we might just need to update some of the assets used.

@sto6 what are your thoughts ?