Skip to content

Commit 4da7558

Browse files
author
R. S. Doiel
committed
prep for v2.2.8 release
1 parent f83e747 commit 4da7558

File tree

9 files changed

+15
-10
lines changed

9 files changed

+15
-10
lines changed

api_routes.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -532,9 +532,10 @@ func Create(w http.ResponseWriter, r *http.Request, api *API, cName string, verb
532532
}
533533
//FIXME: If urlencoded data then redirect for the form to some URL. What is the way to indicate this?
534534
// Early web stuff used a hidden form field for this, seems really clunky.
535-
if contentType == "application/json" {
535+
if contentType == "application/json" || successRedirect == "" {
536536
statusIsOK(w, http.StatusOK, cName, key, "updated", "")
537537
} else {
538+
// NOTE: we build the parameter list if successRedirect is not an empty string.
538539
statusIsOKText(w, r, http.StatusOK, cName, key, "updated", "", fmt.Sprintf("%s?key=%s", successRedirect, key))
539540
}
540541
return
@@ -578,9 +579,10 @@ func Create(w http.ResponseWriter, r *http.Request, api *API, cName string, verb
578579
return
579580
}
580581
//FIXME: If urlencoded data then redirect for the form (is this in the referrer URL?)
581-
if contentType == "application/json" {
582+
if contentType == "application/json" || successRedirect == "" {
582583
statusIsOK(w, http.StatusCreated, cName, key, "created", "")
583584
} else {
585+
// NOTE: we build the parameter list if successRedirect is not an empty string.
584586
statusIsOKText(w, r, http.StatusOK, cName, key, "updated", "", fmt.Sprintf("%s?key=%s", successRedirect, key))
585587
}
586588
return

cli_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,10 +816,13 @@ func TestDataset(t *testing.T) {
816816
t.FailNow()
817817
}
818818

819+
// NOTE: after v2.27 key lists with 1 or more keys get a trailing newline.
820+
// See issue #150 enhancement request.
819821
expectedB = []byte(`1
820822
2
821823
3
822-
4`)
824+
4
825+
`)
823826
args = []string{"keys", cName}
824827
if err := RunCLI(in, out, eout, args); err != nil {
825828
t.Errorf("ran %q, got error %s", strings.Join(args, " "), err)

dataset.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
%dataset(1) user manual | version 2.2.8 be3ab26
1+
%dataset(1) user manual | version 2.2.8 f83e747
22
% R. S. Doiel and Tom Morrell
33
% 2025-06-10
44

datasetd.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
%datasetd(1) user manual | version 2.2.8 be3ab26
1+
%datasetd(1) user manual | version 2.2.8 f83e747
22
% R. S. Doiel
33
% 2025-06-10
44

dsimporter.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
%dsimporter(1) dataset user manual | version 2.2.8 be3ab26
1+
%dsimporter(1) dataset user manual | version 2.2.8 f83e747
22
% R. S. Doiel and Tom Morrell
33
% 2025-06-10
44

dsquery.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
%dsquery(1) dataset user manual | version 2.2.8 be3ab26
1+
%dsquery(1) dataset user manual | version 2.2.8 f83e747
22
% R. S. Doiel and Tom Morrell
33
% 2025-06-10
44

installer.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env pwsh
2-
# generated with CMTools 2.2.8 be3ab26
2+
# generated with CMTools 2.2.8 f83e747
33

44
#
55
# Set the package name and version to install

installer.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/sh
2-
# generated with CMTools 2.2.8 be3ab26
2+
# generated with CMTools 2.2.8 f83e747
33

44
#
55
# Set the package name and version to install

version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const (
1212
ReleaseDate = "2025-06-10"
1313

1414
// ReleaseHash, the Git hash when version.go was generated
15-
ReleaseHash = "be3ab26"
15+
ReleaseHash = "f83e747"
1616
LicenseText = `
1717
1818
Copyright (c) 2022, Caltech

0 commit comments

Comments
 (0)