Apply coding standard

Author: BenMorel

src/BigDecimal.php

@@ -8,6 +8,8 @@
 use Brick\Math\Exception\MathException;
 use Brick\Math\Exception\NumberFormatException;
 use Brick\Math\Exception\RoundingNecessaryException;
+use InvalidArgumentException;
+use LogicException;
 use Override;
 
 /**
@@ -46,21 +48,15 @@ protected function __construct(BigInteger $numerator, BigInteger $denominator, b
             }
 
             if ($denominator->isNegative()) {
-                $numerator   = $numerator->negated();
+                $numerator = $numerator->negated();
                 $denominator = $denominator->negated();
             }
         }
 
-        $this->numerator   = $numerator;
+        $this->numerator = $numerator;
         $this->denominator = $denominator;
     }
 
-    #[Override]
-    protected static function from(BigNumber $number): static
-    {
-        return $number->toBigRational();
-    }
-
     /**
      * Creates a BigRational out of a numerator and a denominator.
      *
@@ -79,8 +75,8 @@ protected static function from(BigNumber $number): static
     public static function nd(
         BigNumber|int|float|string $numerator,
         BigNumber|int|float|string $denominator,
-    ) : BigRational {
-        $numerator   = BigInteger::of($numerator);
+    ): BigRational {
+        $numerator = BigInteger::of($numerator);
         $denominator = BigInteger::of($denominator);
 
         return new BigRational($numerator, $denominator, true);
@@ -91,7 +87,7 @@ public static function nd(
      *
      * @pure
      */
-    public static function zero() : BigRational
+    public static function zero(): BigRational
     {
         /** @var BigRational|null $zero */
         static $zero;
@@ -108,7 +104,7 @@ public static function zero() : BigRational
      *
      * @pure
      */
-    public static function one() : BigRational
+    public static function one(): BigRational
     {
         /** @var BigRational|null $one */
         static $one;
@@ -125,7 +121,7 @@ public static function one() : BigRational
      *
      * @pure
      */
-    public static function ten() : BigRational
+    public static function ten(): BigRational
     {
         /** @var BigRational|null $ten */
         static $ten;
@@ -140,15 +136,15 @@ public static function ten() : BigRational
     /**
      * @pure
      */
-    public function getNumerator() : BigInteger
+    public function getNumerator(): BigInteger
     {
         return $this->numerator;
     }
 
     /**
      * @pure
      */
-    public function getDenominator() : BigInteger
+    public function getDenominator(): BigInteger
     {
         return $this->denominator;
     }
@@ -158,7 +154,7 @@ public function getDenominator() : BigInteger
      *
      * @pure
      */
-    public function quotient() : BigInteger
+    public function quotient(): BigInteger
     {
         return $this->numerator->quotient($this->denominator);
     }
@@ -168,7 +164,7 @@ public function quotient() : BigInteger
      *
      * @pure
      */
-    public function remainder() : BigInteger
+    public function remainder(): BigInteger
     {
         return $this->numerator->remainder($this->denominator);
     }
@@ -180,7 +176,7 @@ public function remainder() : BigInteger
      *
      * @pure
      */
-    public function quotientAndRemainder() : array
+    public function quotientAndRemainder(): array
     {
         return $this->numerator->quotientAndRemainder($this->denominator);
     }
@@ -194,12 +190,12 @@ public function quotientAndRemainder() : array
      *
      * @pure
      */
-    public function plus(BigNumber|int|float|string $that) : BigRational
+    public function plus(BigNumber|int|float|string $that): BigRational
     {
         $that = BigRational::of($that);
 
-        $numerator   = $this->numerator->multipliedBy($that->denominator);
-        $numerator   = $numerator->plus($that->numerator->multipliedBy($this->denominator));
+        $numerator = $this->numerator->multipliedBy($that->denominator);
+        $numerator = $numerator->plus($that->numerator->multipliedBy($this->denominator));
         $denominator = $this->denominator->multipliedBy($that->denominator);
 
         return new BigRational($numerator, $denominator, false);
@@ -214,12 +210,12 @@ public function plus(BigNumber|int|float|string $that) : BigRational
      *
      * @pure
      */
-    public function minus(BigNumber|int|float|string $that) : BigRational
+    public function minus(BigNumber|int|float|string $that): BigRational
     {
         $that = BigRational::of($that);
 
-        $numerator   = $this->numerator->multipliedBy($that->denominator);
-        $numerator   = $numerator->minus($that->numerator->multipliedBy($this->denominator));
+        $numerator = $this->numerator->multipliedBy($that->denominator);
+        $numerator = $numerator->minus($that->numerator->multipliedBy($this->denominator));
         $denominator = $this->denominator->multipliedBy($that->denominator);
 
         return new BigRational($numerator, $denominator, false);
@@ -234,11 +230,11 @@ public function minus(BigNumber|int|float|string $that) : BigRational
      *
      * @pure
      */
-    public function multipliedBy(BigNumber|int|float|string $that) : BigRational
+    public function multipliedBy(BigNumber|int|float|string $that): BigRational
     {
         $that = BigRational::of($that);
 
-        $numerator   = $this->numerator->multipliedBy($that->numerator);
+        $numerator = $this->numerator->multipliedBy($that->numerator);
         $denominator = $this->denominator->multipliedBy($that->denominator);
 
         return new BigRational($numerator, $denominator, false);
@@ -253,11 +249,11 @@ public function multipliedBy(BigNumber|int|float|string $that) : BigRational
      *
      * @pure
      */
-    public function dividedBy(BigNumber|int|float|string $that) : BigRational
+    public function dividedBy(BigNumber|int|float|string $that): BigRational
     {
         $that = BigRational::of($that);
 
-        $numerator   = $this->numerator->multipliedBy($that->denominator);
+        $numerator = $this->numerator->multipliedBy($that->denominator);
         $denominator = $this->denominator->multipliedBy($that->numerator);
 
         return new BigRational($numerator, $denominator, true);
@@ -266,11 +262,11 @@ public function dividedBy(BigNumber|int|float|string $that) : BigRational
     /**
      * Returns this number exponentiated to the given value.
      *
-     * @throws \InvalidArgumentException If the exponent is not in the range 0 to 1,000,000.
+     * @throws InvalidArgumentException If the exponent is not in the range 0 to 1,000,000.
      *
      * @pure
      */
-    public function power(int $exponent) : BigRational
+    public function power(int $exponent): BigRational
     {
         if ($exponent === 0) {
             $one = BigInteger::one();
@@ -285,7 +281,7 @@ public function power(int $exponent) : BigRational
         return new BigRational(
             $this->numerator->power($exponent),
             $this->denominator->power($exponent),
-            false
+            false,
         );
     }
 
@@ -298,7 +294,7 @@ public function power(int $exponent) : BigRational
      *
      * @pure
      */
-    public function reciprocal() : BigRational
+    public function reciprocal(): BigRational
     {
         return new BigRational($this->denominator, $this->numerator, true);
     }
@@ -308,7 +304,7 @@ public function reciprocal() : BigRational
      *
      * @pure
      */
-    public function abs() : BigRational
+    public function abs(): BigRational
     {
         return new BigRational($this->numerator->abs(), $this->denominator, false);
     }
@@ -318,7 +314,7 @@ public function abs() : BigRational
      *
      * @pure
      */
-    public function negated() : BigRational
+    public function negated(): BigRational
     {
         return new BigRational($this->numerator->negated(), $this->denominator, false);
     }
@@ -328,7 +324,7 @@ public function negated() : BigRational
      *
      * @pure
      */
-    public function simplified() : BigRational
+    public function simplified(): BigRational
     {
         $gcd = $this->numerator->gcd($this->denominator);
 
@@ -339,19 +335,19 @@ public function simplified() : BigRational
     }
 
     #[Override]
-    public function compareTo(BigNumber|int|float|string $that) : int
+    public function compareTo(BigNumber|int|float|string $that): int
     {
         return $this->minus($that)->getSign();
     }
 
     #[Override]
-    public function getSign() : int
+    public function getSign(): int
     {
         return $this->numerator->getSign();
     }
 
     #[Override]
-    public function toBigInteger() : BigInteger
+    public function toBigInteger(): BigInteger
     {
         $simplified = $this->simplified();
 
@@ -363,40 +359,41 @@ public function toBigInteger() : BigInteger
     }
 
     #[Override]
-    public function toBigDecimal() : BigDecimal
+    public function toBigDecimal(): BigDecimal
     {
         return $this->numerator->toBigDecimal()->exactlyDividedBy($this->denominator);
     }
 
     #[Override]
-    public function toBigRational() : BigRational
+    public function toBigRational(): BigRational
     {
         return $this;
     }
 
     #[Override]
-    public function toScale(int $scale, RoundingMode $roundingMode = RoundingMode::UNNECESSARY) : BigDecimal
+    public function toScale(int $scale, RoundingMode $roundingMode = RoundingMode::UNNECESSARY): BigDecimal
     {
         return $this->numerator->toBigDecimal()->dividedBy($this->denominator, $scale, $roundingMode);
     }
 
     #[Override]
-    public function toInt() : int
+    public function toInt(): int
     {
         return $this->toBigInteger()->toInt();
     }
 
     #[Override]
-    public function toFloat() : float
+    public function toFloat(): float
     {
         $simplified = $this->simplified();
+
         return $simplified->numerator->toFloat() / $simplified->denominator->toFloat();
     }
 
     #[Override]
-    public function __toString() : string
+    public function __toString(): string
     {
-        $numerator   = (string) $this->numerator;
+        $numerator = (string) $this->numerator;
         $denominator = (string) $this->denominator;
 
         if ($denominator === '1') {
@@ -425,17 +422,23 @@ public function __serialize(): array
      *
      * @param array{numerator: BigInteger, denominator: BigInteger} $data
      *
-     * @throws \LogicException
+     * @throws LogicException
      */
     public function __unserialize(array $data): void
     {
         /** @phpstan-ignore isset.initializedProperty */
         if (isset($this->numerator)) {
-            throw new \LogicException('__unserialize() is an internal function, it must not be called directly.');
+            throw new LogicException('__unserialize() is an internal function, it must not be called directly.');
         }
 
         /** @phpstan-ignore deadCode.unreachable */
         $this->numerator = $data['numerator'];
         $this->denominator = $data['denominator'];
     }
+
+    #[Override]
+    protected static function from(BigNumber $number): static
+    {
+        return $number->toBigRational();
+    }
 }

src/BigInteger.php

@@ -12,23 +12,23 @@ final class DivisionByZeroException extends MathException
     /**
      * @pure
      */
-    public static function divisionByZero() : DivisionByZeroException
+    public static function divisionByZero(): DivisionByZeroException
     {
         return new self('Division by zero.');
     }
 
     /**
      * @pure
      */
-    public static function modulusMustNotBeZero() : DivisionByZeroException
+    public static function modulusMustNotBeZero(): DivisionByZeroException
     {
         return new self('The modulus must not be zero.');
     }
 
     /**
      * @pure
      */
-    public static function denominatorMustNotBeZero() : DivisionByZeroException
+    public static function denominatorMustNotBeZero(): DivisionByZeroException
     {
         return new self('The denominator of a rational number cannot be zero.');
     }

src/BigNumber.php

@@ -6,6 +6,11 @@
 
 use Brick\Math\BigInteger;
 
+use function sprintf;
+
+use const PHP_INT_MAX;
+use const PHP_INT_MIN;
+
 /**
  * Exception thrown when an integer overflow occurs.
  */
@@ -14,10 +19,10 @@ final class IntegerOverflowException extends MathException
     /**
      * @pure
      */
-    public static function toIntOverflow(BigInteger $value) : IntegerOverflowException
+    public static function toIntOverflow(BigInteger $value): IntegerOverflowException
     {
         $message = '%s is out of range %d to %d and cannot be represented as an integer.';
 
-        return new self(\sprintf($message, (string) $value, PHP_INT_MIN, PHP_INT_MAX));
+        return new self(sprintf($message, (string) $value, PHP_INT_MIN, PHP_INT_MAX));
     }
 }

src/BigRational.php

@@ -4,9 +4,11 @@
 
 namespace Brick\Math\Exception;
 
+use RuntimeException;
+
 /**
  * Base class for all math exceptions.
  */
-class MathException extends \RuntimeException
+class MathException extends RuntimeException
 {
 }