Skip to content

More possible issues with vertical-position #95

@bertfrees

Description

@bertfrees

I have made the following test OBFL:

<obfl version="2011-1" xml:lang="en">
  <layout-master name="body" page-width="10" page-height="12" duplex="false">
    <default-template>
      <header/>
      <footer/>
    </default-template>
  </layout-master>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block vertical-align="before" vertical-position="8">
      <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block vertical-align="before" vertical-position="8" margin-bottom="1">
      <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block margin-bottom="1">
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block>
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
      <block>⠉⠉⠉⠉⠉</block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block margin-bottom="1">
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
      <block>⠉⠉⠉⠉⠉</block>
    </block>
  </sequence>
</obfl>

which results in this PEF:

<pef>
    <body>
        <volume cols="10" rows="12" rowgap="0" duplex="false">
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                    <row>⠉⠉⠉⠉⠉</row>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                </page>
            </section>
        </volume>
    </body>
</pef>

@joeha480 Could you change this PEF according to what is expected according to you. The spec is not entirely clear about this. I would think the position of the block with vertical-position should not be affected by the ⠉⠉⠉⠉⠉ block after it. But also the fact that the position is affected by margin-bottom seems a bit strange.

If you can fix the expected output I will try to fix the issue.

Note that my fix for #92 did not fix this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions