Improve performance of Box::collectRemainingFiles()

The `->notPath()` filter of Symfony Finder is either accepting a “literal path”
or a regular expression and converts each literal path to a regular expression
and then filters the file stream by applying each regex individually. This
leads to O(bufferedFileNames^2) calls to `preg_match()`, well over 20 million
for PHPStan.

Fix this by performing a simple `in_array()` check on the buffered files. This
brings down the time to compile PHPStan from 2:35 to 0:25 on my machine.

I have verified that the resulting PHPStan Phar hash is identical before and
after this change.

Fixes #1551.

Author: TimWolla

src/Box.php

@@ -48,9 +48,8 @@
 use function extension_loaded;
 use function file_exists;
 use function getcwd;
+use function in_array;
 use function is_object;
-use function iter\fromPairs;
-use function iter\map;
 use function openssl_pkey_export;
 use function openssl_pkey_get_details;
 use function openssl_pkey_get_private;
@@ -222,18 +221,15 @@ private static function collectRemainingFiles(
         string $tmp,
         array $bufferedFileNames,
     ): iterable {
-        return fromPairs(
-            map(
-                static fn (SplFileInfo $fileInfo) => [
-                    $fileInfo->getRelativePathname(),
-                    $fileInfo->getPathname(),
-                ],
-                Finder::create()
-                    ->files()
-                    ->in($tmp)
-                    ->notPath($bufferedFileNames),
-            ),
-        );
+        $finder = Finder::create()->files()->in($tmp);
+
+        foreach ($finder as $fileInfo) {
+            if (in_array($fileInfo->getRelativePathname(), $bufferedFileNames, true)) {
+                continue;
+            }
+
+            yield $fileInfo->getRelativePathname() => $fileInfo->getPathname();
+        }
     }
 
     /**