Any user can return any borrowed tool

[destos]

Describe the bug
When browsing tools, if another user has borrowed a tool. You're able to return it even, if it isn't your tool or you aren't the one borrowing it.

Expected behavior
When you've borrowed a tool you're able to return it. If a tool of yours is borrowed you're also able to set it as returned.

[varunu28]

@destos I will like to work on this issue. Can you please assign it to me?

[destos]

@varunu28 It won't let me assign it to you. Possibly due to you not being in the organization. I would just start working on it. First, get toolhub setup locally if you haven't already. At that point, we can discuss the implementation of this feature.

[varunu28]

@destos Sure thing. I will get started with the setup on my local machine

[varunu28]

@destos I have finished the setup locally and was also able to replicate the issue on my local machine.

Here the hammer was created by user Varun Upadhyay and then user Varun Sjsu was able to return the tool. I have a feeling that there is a user check missing in the tool return function. We can discuss it in detail and then I can go ahead with implementing the fix for this.

[destos]

@varunu28 Glad you got it all setup!
The template tags around borrowing are in the borrowing app:
https://github.com/bkmakerspace/toolhub/tree/master/borrowing

It was implemented as two views, a borrow, and a return. They take post data from the templatetag form code and perform the return/borrow action. The validation logic probably needs to go in that form. https://github.com/bkmakerspace/toolhub/blob/master/borrowing/forms.py

[varunu28]

@destos Thanks a ton. Will get started on this