uses `mkdirp`, not available on 3 machines that I have tried to install biojs libs (build with slush-biojs) on

[doomedramen]

[doomedramen]

biojs-vcf@1.1.0 build /Users/pagem/Documents/workspace/geefu.io/node_modules/biojs-vcf
mkdirp build && browserify -r ./:biojs-vcf -o build/vcf.js

sh: mkdirp: command not found

[doomedramen]

Found the issue, the mkdirp is put into the dev dependencies, even though in production you would still need the lib to be built. I think it would be worth moving that from dev-dependencies to dependencies in the output package.json

[manuelcorpas]

Forwarded this to Dennis

[DennisSchwartz]

Hey Martin. Feel free to issue a pull request if you know how to change this. Otherwise I'm happy to do it myself.

[doomedramen]

Just found out, doing a normal install (with dev deps) does not help ether.

Just passed my project that that a lib (made with biojs-slush) to travis and it cant build ether.

My project: https://github.com/TeamMacLean/geefu.io/blob/master/package.json

which includes:
"biojs-vcf": "^1.1.0",

gives the following error on my machines and travis:

biojs-vcf@1.1.0 build /home/travis/build/TeamMacLean/geefu.io/node_modules/biojs-vcf
mkdirp build && browserify -r ./:biojs-vcf -o build/vcf.js
sh: 1: mkdirp: not found

[doomedramen]

My assumption is that biojs-slush makes mkdirp and browserify a dep of the lib that is generated and that it expects to use both of these from the node_modules/.bin folder but because it is a package on top of this that is being built it does not look in that .bin folder, instead it looks in the one of the top level package.
aka, it would build fine if you were JUST building the lib generated with slush-biojs but if you have included said lib in another package.json it does not work as it cannot resolve the .bin folder from that lib

https://travis-ci.org/TeamMacLean/geefu.io/jobs/95320067

[doomedramen]

Just tested this,
if I do npm install -g biojs-vcf is works fine,
if I include biojs-vcf in a package file and do npm install it complains about mkdirp and browserify not existing.
Do you know any other libs built with slush-biojs that I could test?

[DennisSchwartz]

Mhm we're currently in our team meeting. I will take a look at this after. You could try my packages, they are created using slush-biojs if that's what you mean. They are called mplexnet and mplexviz-ngraph (also don't judge my bad coding).

[doomedramen]

ill give them a go now and let you know.

[doomedramen]

yep, same issue with mplexnet, if I install it on its own it is fine (I assume it can see browserify and mkdirp in its .bin folder) but if installed a part of another project it fails.

steps to test:

mkdir test
cd test
npm init -y
npm install mplexnet --save

(make sure browserify and mkdirp are not installed globally before testing or it will give false results)
npm rm browserify -g
npm rm mkdirp -g

[DennisSchwartz]

We ran into this problem before. One solution is to include browserify and mkdirp in the dependencies. But that will include dev tools in your build and especially browserify is a pretty big package. We didn't come up with a solution yet.

I think what we would need to do is to install the necessary build tools without including them in the actual bundle file. Do you know of any good way to do that?

[doomedramen]

I can only think or dirty, hacky ways, not ideal.

[DennisSchwartz]

I came up with the same conclusion and then forgot about it.
I think a clear error message about whats the problem would already help.

How about including a bash script with slush-biojs that will be called in the build command to check if mkdirp and browserify are available and install them if necessary?
Do they have to be installed globally to be called from command line?

I'm thinking of something like:

"build": "sh checkDeps.sh && mkdirp build && browserify -r ./:mplexviz-ngraph -o build/bundle.js"

[DennisSchwartz]

Mhm that would of course only work on unix-like environments

[doomedramen]

You could just not force browserify...