Skip to content

Commit 68fd518

Browse files
committed
fix: correct URL format in mapCell2Accession tests and remove deprecated test cases
1 parent d3e8914 commit 68fd518

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

R/cellosaurus_helpers.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
opts <- list()
8080

8181
if(apiResource == "search/cell-line"){
82-
"https://api.cellosaurus.org/search/cell-line?q=idsy%3ADOR%2013&sort=ac%20asc&fields=ac%2Cid%2Csy%2Cmisspelling%2Cdr%2Ccc&format=txt&rows=10000"
8382
opts$q <- paste0(query, collapse = " ")
8483
} else if(apiResource == "cell-line"){
8584
url$path <- .buildURL(url$path, query)

tests/testthat/test_cellosaurus.R

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,6 @@ test_that("mapCell2Accession works as expected", {
1515

1616
})
1717

18-
test_that("mapCell2Accession prioritizePatient works as expected", {
19-
cell_line <- "BT474"
20-
21-
result1 <- mapCell2Accession(
22-
cell_line)
23-
24-
expect_data_table(result1, nrows = 1, ncols = 3)
25-
expect_named(result1, c("cellLineName", "accession", "query"))
26-
expect_equal(result1$accession, "CVCL_0179")
27-
expect_equal(result1$cellLineName, "BT-474")
28-
29-
expect_error(mapCell2Accession("BT474", numResults = -1, from = "idsy"))
30-
})
31-
3218
test_that("mapCell2Accession fuzzy search works as expected", {
3319
cell_line <- "BT474"
3420

@@ -39,8 +25,6 @@ test_that("mapCell2Accession fuzzy search works as expected", {
3925
expect_equal(result1$accession, "CVCL_0179")
4026
expect_equal(result1$cellLineName, "BT-474")
4127
expect_named(result1, c("cellLineName", "accession", "query"))
42-
43-
expect_error(mapCell2Accession("BT474", numResults = -1, from = "idsy"))
4428
})
4529

4630
test_that("mapCell2Accession with multiple cell lines works as expected", {
@@ -53,8 +37,6 @@ test_that("mapCell2Accession with multiple cell lines works as expected", {
5337
expect_named(result1, c("cellLineName", "accession", "query"))
5438
expect_equal(result1$accession, c("CVCL_0179", "CVCL_0030"))
5539
expect_equal(result1$cellLineName, c("BT-474", "HeLa"))
56-
57-
expect_error(mapCell2Accession("BT474", numResults = -1, from = "idsy"))
5840
})
5941

6042
test_that("mapCell DOR 13 works", {
@@ -81,7 +63,7 @@ test_that("mapCell DOR 13 works", {
8163
test_that("query only paramater works",{
8264
result1 <- mapCell2Accession("DOR 13", query_only = TRUE)
8365

84-
expected <- "https://api.cellosaurus.org/search/cell-line?q=idsy%3ADOR%2013&sort=ac%20asc&fields=ac%2Cid%2Csy%2Cmisspelling%2Cdr%2Ccc%2Cca%2Cdi%2Cag%2Csx%2Chi&format=txt&rows=10000"
66+
expected <- "https://api.cellosaurus.org//search/cell-line?q=idsy%3ADOR%2013&sort=ac%20asc&fields=ac%2Cid%2Csy%2Cmisspelling%2Cdr%2Ccc%2Cca%2Cdi%2Cag%2Csx%2Chi&format=txt&rows=10000"
8567
expect_equal(result1[[1]], expected)
8668
expect_equal(names(result1), "DOR 13")
8769
})

0 commit comments

Comments
 (0)