Skip to content

Issue: Typo in check_any_debtors function causing potential bug #23

@dailypush

Description

@dailypush

Typo in check_any_debtors function causing potential bug

I noticed a small issue in the check_any_debtors function in people.php which might cause unexpected behavior.

function check_any_debtors($emails) {
    global $db;
    $get = $db->prepare('SELECT count(*) FROM debtors WHERE email=? AND owner=?');
    foreach($emails as $email) {
        $get->execute(array($email, $_SESSION['tabby_loggedin']));
        if($get->fetchColumn() > 0) {
            return FALSE;
        }
    }
    return T;
}

In the last line of the function, it should return TRUE instead of T. The current implementation might lead to a runtime error or unexpected behavior since T is not a defined constant in the code.

Proposed solution:

Replace return T; with return TRUE; to fix the issue:

function check_any_debtors($emails) {
    // ...
    return TRUE;
}

Please let me know if you have any questions or need further clarification.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions