Newly created plan not displayed

When creating a new plan attachments are not provided which was causing
problem loading the plan.

Author: Brijesh

src/api/plan.js

@@ -109,12 +109,14 @@ export const savePlan = async (plan, user = {}) => {
   await saveMinisterIssues(planId, ministerIssues, newPastures);
   await saveAdditionalRequirements(planId, additionalRequirements);
 
-  // Only save attachments that haven't been saved individually
-  // (attachments with UUID ids haven't been saved to database yet)
-  if ((isUserAgrologist(user) && canUserAddAttachments(plan, user)) || isUserAdmin(user)) {
-    const unsavedAttachments = files.filter((file) => uuid.isUUID(file.id));
-    if (unsavedAttachments.length > 0) {
-      await saveAttachments(planId, unsavedAttachments);
+  if (files && files.length > 0) {
+    // Only save attachments that haven't been saved individually
+    // (attachments with UUID ids haven't been saved to database yet)
+    if ((isUserAgrologist(user) && canUserAddAttachments(plan, user)) || isUserAdmin(user)) {
+      const unsavedAttachments = files.filter((file) => uuid.isUUID(file.id));
+      if (unsavedAttachments.length > 0) {
+        await saveAttachments(planId, unsavedAttachments);
+      }
     }
   }
 

src/providers/PlanProvider.js

@@ -78,9 +78,14 @@ export const PlanProvider = ({ children, storePlan }) => {
   const savePlan = async (plan) => {
     try {
       setSavingPlan(true);
-
-      const planId = await API.savePlan(plan, user);
-      await fetchPlan(planId);
+      let planId;
+      try {
+        planId = await API.savePlan(plan, user);
+        await fetchPlan(planId);
+      } catch (e) {
+        console.error('Error saving plan:', e);
+        throw e;
+      }
 
       return planId;
     } catch (e) {

src/utils/helper/plan.js

@@ -29,11 +29,14 @@ export const getPlanTypeDescription = (plan = {}, amendmentTypes) => {
 };
 
 export const scrollIntoView = (elementId) => {
-  document.getElementById(elementId).scrollIntoView({
-    behavior: 'smooth',
-    block: 'start',
-    inline: 'nearest',
-  });
+  const element = document.getElementById(elementId);
+  if (element) {
+    element.scrollIntoView({
+      behavior: 'smooth',
+      block: 'start',
+      inline: 'nearest',
+    });
+  }
 };
 
 // for plans extending past agreement date, extend usage