Skip to content

Commit 2a3eb77

Browse files
committed
Standardize ergo bottom row keys
1 parent 19a13a7 commit 2a3eb77

File tree

5 files changed

+12
-26
lines changed

5 files changed

+12
-26
lines changed

keyboards/eco/keymaps/bcat/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ on a Pro Micro (or compatible) controller.
88

99
* Based on [split 3x6+3](/layouts/split_3x6_3/bcat) layout. See that page for
1010
detailed rationale on keymap design.
11-
* The alpha keys are separated by an extra two columns in the middle to provide
12-
a little more hand separation, similar to a split keyboard.
11+
* The alpha keys are spaced around the middle two columns, providing a little
12+
more hand separation, similar to a split keyboard.
1313
* The top three rows of the extra middle columns feature navigation keys and
1414
brackets/braces. I don't really use dedicated keys for these, but I had the
1515
keycaps, so I figured I may as well put them there.
1616
* I have a Left Alt and Right Super key on the bottom row just like my
17-
[Lily58](/keyboards/lily58/keymaps/bcat).
17+
[Altair-X](/keyboards/ai03/altair_x/keymaps/bcat).
1818
* The two keys in each bottom corner are unbound, as is the 2U spacebar in the
1919
center of the bottom row. These keys are too inconvenient to reach, and
2020
there's nothing really useful to bind them to anyway.

keyboards/lily58/keymaps/bcat/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ per side.
1313
* The dedicated Hyphen/Underscore and Equals/Plus keys on the number row are
1414
placed in the same positions as on the ErgoDox EZ. (There's no real reason for
1515
this; I just had to do _something_ with those keys.)
16-
* The extra thumb keys on the bottom row are used for a Left Alt key (for easier
17-
Alt+Tab, Alt+F4, etc.) and a dedicated Super key.
18-
* The extra thumb keys below the controllers are bound to browser zoom keys.
16+
* The extra bottom row keys are mapped to Alt and Super for convenience, just as
17+
they are on my [Altair-X](/keyboards/ai03/altair_x/bcat).
18+
* The additional keys below the controllers are bound to browser zoom keys.
1919
</details>
2020

2121
| Default layer ([KLE](http://www.keyboard-layout-editor.com/#/gists/e0eb3af65961e9fd612dcff3ddd88e4f)) |

keyboards/yanghu/unicorne/keymaps/bcat/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
# bcat's Unicorne layout
22

33
The [Unicorne](https://github.com/yanghu/unicorne) keyboard is an un-split Crkbd
4-
with slightly altered columbar stagger and two extra thumb keys (including
4+
with slightly altered columnar stagger and two extra thumb keys (including
55
rotary encoder compatibility).
66

77
<details>
88
<summary>Layout notes</summary>
99

1010
* Based on [split 3x6+3](/layouts/split_3x6_3/bcat) layout. See that page for
1111
detailed rationale on keymap design.
12-
* I built my Unicorne with rotary encoders: The left scrolls vertically and the
13-
right adjusts volume. These were a fun gimmick at first, but in retrospect,
14-
I'd prefer to use that as Alt and Super keys instead.
12+
* I built my Unicorne without encoders, as I've always found them a fun gimmick,
13+
but not something I regularly use.
14+
* Instead, the extra bottom row keys are mapped to Alt and Super for
15+
convenience, just as they are on my [Altair-X](/keyboards/ai03/altair_x/bcat).
1516
* Since the Unicorne has a speaker, I added bindings on the Adjust layer to
1617
activate and configure QMK's [music
1718
mode](https://docs.qmk.fm/features/audio#music-mode).

keyboards/yanghu/unicorne/keymaps/bcat/keymap.c

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
1515
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC,
1616
KC_ESC, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT,
1717
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT,
18-
KC_MPLY, KC_LCTL, TL_LOWR, KC_SPC, KC_ENT, TL_UPPR, KC_RALT, KC_MUTE
18+
KC_LALT, KC_LCTL, TL_LOWR, KC_SPC, KC_ENT, TL_UPPR, KC_RALT, KC_RGUI
1919
),
2020
[LAYER_LOWER] = LAYOUT(
2121
CC_ALTT, KC_EXLM, KC_AT, KC_HASH, KC_DLR, KC_PERC, KC_CIRC, KC_AMPR, KC_ASTR, KC_LPRN, KC_RPRN, _______,
@@ -38,21 +38,6 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
3838
// clang-format on
3939
};
4040

41-
bool encoder_update_user(uint8_t index, bool clockwise) {
42-
switch (index) {
43-
case 0:
44-
// Left encoder (scrolling):
45-
tap_code(clockwise ? KC_PGDN : KC_PGUP);
46-
return false;
47-
case 1:
48-
// Right encoder (volume):
49-
tap_code(clockwise ? KC_VOLU : KC_VOLD);
50-
return false;
51-
default:
52-
return true;
53-
}
54-
}
55-
5641
#if defined(OLED_ENABLE)
5742
oled_rotation_t oled_init_user(oled_rotation_t rotation) {
5843
return OLED_ROTATION_270;
13.4 KB
Loading

0 commit comments

Comments
 (0)