Ensure the requester of MagicLink is the one to use it

[udiudi]

It's not a critical vulnerability, but I think it should be addressed to tighten the authentication process.

Simple Reproduction Steps

I'll use Fizzy's seed data as an example:

1. [email protected] signs-in, has a screen to write the code (and an email is sent).
2. [email protected] signs-in, has a screen to write the code. If [email protected] writes [email protected]'s code (for whatever security breach), he's signed-in as [email protected] as a result.

The Riskier Scenarios

This vulnerability can allow phishing attacks - as we usually see in the realm of two-factor auth ("You got a code in your email, can you send it over?").

Not very critical - but should be addressed, IMO.

The Fix

Ensuring that the user who requests a magic link is the only one who can use it to sign-in with a session based check session[:pending_auth_email].

Proposed PR here

[monorkin]

Hey @udiudi, I ported your PR over to our repo and added you as the co-author.
You can check the PR out here.
If you are ok with this, and the PR looks good let me know and I'll merge it.

[udiudi]

Thank you @monorkin, it's fine by me

[monorkin]

I just merged the PR. Thank you for contributing this @udiudi !