diff --git a/workspaces/azure-devops/.changeset/khaki-shrimps-kick.md b/workspaces/azure-devops/.changeset/khaki-shrimps-kick.md new file mode 100644 index 00000000000..e6251a08bdb --- /dev/null +++ b/workspaces/azure-devops/.changeset/khaki-shrimps-kick.md @@ -0,0 +1,5 @@ +--- +'@backstage-community/plugin-scaffolder-backend-module-azure-devops': minor +--- + +**BREAKING** Fixed bug in `createAzureDevopsRunPipelineAction` where `pipelineRun.result` returned an integer instead of the corresponding string diff --git a/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.test.ts b/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.test.ts index 3bceebb5247..dbef6968fe2 100644 --- a/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.test.ts +++ b/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.test.ts @@ -241,11 +241,11 @@ describe('publish:azure', () => { it('should output pipelineRunStatus if available', async () => { mockPipelineClient.runPipeline.mockImplementation(() => ({ _links: { web: { href: 'http://pipeline-run-url.com' } }, - result: 'InProgress', + result: '1', })); mockPipelineClient.getRun.mockImplementation(() => ({ _links: { web: { href: 'http://pipeline-run-url.com' } }, - result: 'InProgress', + result: '1', })); await action.handler({ @@ -264,7 +264,7 @@ describe('publish:azure', () => { ); expect(mockContext.output).toHaveBeenCalledWith( 'pipelineRunStatus', - 'InProgress', + 'Succeeded', ); }); diff --git a/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.ts b/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.ts index 0de7ff319dd..9ae23cf9de2 100644 --- a/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.ts +++ b/workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops/src/actions/devopsRunPipeline.ts @@ -212,7 +212,11 @@ export function createAzureDevopsRunPipelineAction(options: { // Log the pipeline run result if available if (pipelineRun.result) { ctx.logger.info( - `Pipeline run result: ${pipelineRun.result.toString()}`, + `Pipeline run result: ${ + pipelineRun.result + ? RunResult[pipelineRun.result] + : RunResult.Unknown + }`, ); } @@ -227,7 +231,10 @@ export function createAzureDevopsRunPipelineAction(options: { ctx.output('pipelineRunUrl', pipelineRun._links.web.href); ctx.output('pipelineRunId', pipelineRun.id!); - ctx.output('pipelineRunStatus', pipelineRun.result?.toString()); + ctx.output( + 'pipelineRunStatus', + pipelineRun.result ? RunResult[pipelineRun.result] : RunResult.Unknown, + ); ctx.output('pipelineTimeoutExceeded', timeoutExceeded); ctx.output('pipelineOutput', pipelineRun.variables); },