Skip to content

Commit 2803509

Browse files
committed
update the doc
1 parent 1c4b18e commit 2803509

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

awscrt/s3.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ class S3ChecksumConfig:
145145
@dataclass
146146
class S3FileIoOptions:
147147
"""
148+
WARNING: experimental/unstable, the default behavior is subjected to change in the future.
148149
Controls how client performance file I/O operations.
149150
Only applies to the file based workload.
150151
Notes: only applies when `send_filepath` is set from the request.
@@ -153,19 +154,20 @@ class S3FileIoOptions:
153154
should_stream: bool = False
154155
"""
155156
Skip buffering the part in memory before sending the request.
156-
If set, set the `disk_throughput` to be reasonable align with the available disk throughput.
157-
Otherwise, the transfer may fail with connection starvation.
157+
158+
Default to false on small objects, and true when the object size exceed a certain threshold.
158159
"""
159160

160161
disk_throughput_gbps: (Optional[float]) = 0.0
161162
"""
162163
The estimated disk throughput. Only be applied when `streaming_upload` is true.
163164
in gigabits per second (Gbps).
164-
When doing upload with streaming, it's important to set the disk throughput to prevent the connection starvation.
165165
166166
Notes: There are possibilities that cannot reach the all available disk throughput:
167167
1. Disk is busy with other applications
168168
2. OS Cache may cap the throughput, use `direct_io` to get around this.
169+
170+
Default to `throughput_target_gbps`.
169171
"""
170172

171173
direct_io: bool = False

0 commit comments

Comments
 (0)