ba-script.sh not working properly #39
Description
Issue1
After compiling I obtain the following artifact: emr-user-role-mapper-application-1.2.0-SNAPSHOT-jar-with-dependencies-and-exclude-classes.jar
On the amazon-emr-user-role-mapper/emr-user-role-mapper-application/usr/install/ba-script.sh we have hardcoded the following:
echo "Getting emr-user-role-mapper-application-1.1.0-jar-with-dependencies-and-exclude-classes.jar from S3"
sudo aws s3 cp s3://${BUCKET}/${S3_PATH}/emr-user-role-mapper-application-1.1.0-jar-with-dependencies-and-exclude-classes.jar /usr/share/aws/emr/user-role-mapper/lib/
The version should not be hardcoded in order to avoid a NotFound exception.
Issue 2
The location of mappings.json is setup inside user-role-mapper.properties (rolemapper.s3.bucket + rolemapper.s3.key).
On the amazon-emr-user-role-mapper/emr-user-role-mapper-application/usr/install/ba-script.sh we have hardcoded the following:
sudo aws s3 cp s3://${BUCKET}/${S3_PATH}/mappings.json /emr/user-role-mapper/conf/
It would be better to retrieve the properties value from user-role-mapper.properties and to use those.