Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

32bit windows build fails with Electron 10 #58

@bohemius

Description

@bohemius

Prerequisites

Description

When building the solution for x86 (32bit Windows) using MSBuild.exe it fails on C4309 warning. I'm using this module with Electron 10.

Steps to Reproduce

  1. Clone the repo.
  2. Build the solution in VS using 32 architecture.
  3. Build fails with error on C4309 warning.

Expected behavior:

Warning is ignored and build completes.

Actual behavior:

Warning is thrown and build is interrupted.

Reproduces how often:

100%

Versions

2.0.16

Additional Information

This can be mitigated by using either one of these

  • /WX- switch to ignore warnings
  • changing 'WarnAsError': 'false' in binding.gyp
  • adding 4309 to the ignored warnings list in binding.gyp

Pull request with change will be created.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions