Placing a guard for undefined behaviour that appears to trigger sanitizers.

FAPG · Laguna1989 · commit 3bc511d91cb5 · 2025-07-08T18:58:36.000+02:00
diff --git a/ApprovalTests/integrations/catch/Catch2Approvals.h b/ApprovalTests/integrations/catch/Catch2Approvals.h
@@ -48,7 +48,10 @@ struct Catch2ApprovalListener : Catch::TestEventListenerBase
 
     virtual void sectionEnded(Catch::SectionStats const& /*sectionStats*/) override
     {
-        currentTest.sections.pop_back();
+        if (!currentTest.sections.empty())
+        {
+            currentTest.sections.pop_back();
+        }
     }
 };
 //}

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,10 @@ struct Catch2ApprovalListener : Catch::TestEventListenerBase`
`48`	`48`
`49`	`49`	`virtual void sectionEnded(Catch::SectionStats const& /sectionStats/) override`
`50`	`50`	`{`
`51`		`- currentTest.sections.pop_back();`
	`51`	`+ if (!currentTest.sections.empty())`
	`52`	`+ {`
	`53`	`+ currentTest.sections.pop_back();`
	`54`	`+ }`
`52`	`55`	`}`
`53`	`56`	`};`
`54`	`57`	`//}`