ORC-1942: Fix PhysicalFsWriter not to change ZstdCodec's default option

### What changes were proposed in this pull request?

This PR aims to fix `PhysicalFsWriter` to change `tempOptions` directly.

### Why are the changes needed?

In the following code path, `tempOptions` is supposed to be updated and used. However, `codec.getDefaultOptions() instanceof ZstdCodec.ZstdOptions options` code is currently updating the return value of `codec.getDefaultOptions()` via a variable `options`.

https://github.com/apache/orc/blob/d3843bc043bea97bdd81a0f8e1fab3329efc7308/java/core/src/java/org/apache/orc/impl/PhysicalFsWriter.java#L118-L127

Technically, `ZstdCodec.getDefaultOptions()` returns the final static variable. This AS-IS code is trying to change this static object which leads unintended side-effects. We should avoid this code pattern.

https://github.com/apache/orc/blob/d3843bc043bea97bdd81a0f8e1fab3329efc7308/java/core/src/java/org/apache/orc/impl/ZstdCodec.java#L150-L156

### How was this patch tested?

Pass the CIs with a newly added test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2304 from dongjoon-hyun/ORC-1942.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 3c63bf7)
Signed-off-by: Dongjoon Hyun <[email protected]>

Author: dongjoon-hyun

java/core/src/java/org/apache/orc/impl/PhysicalFsWriter.java

@@ -116,8 +116,7 @@ public PhysicalFsWriter(FSDataOutputStream outputStream,
     CompressionCodec codec = OrcCodecPool.getCodec(opts.getCompress());
     if (codec != null){
       CompressionCodec.Options tempOptions = codec.getDefaultOptions();
-      if (codec instanceof ZstdCodec &&
-              codec.getDefaultOptions() instanceof ZstdCodec.ZstdOptions options) {
+      if (codec instanceof ZstdCodec && tempOptions instanceof ZstdCodec.ZstdOptions options) {
         OrcFile.ZstdCompressOptions zstdCompressOptions = opts.getZstdCompressOptions();
         if (zstdCompressOptions != null) {
           options.setLevel(zstdCompressOptions.getCompressionZstdLevel());

java/core/src/java/org/apache/orc/impl/ZstdCodec.java

@@ -152,7 +152,7 @@ public int hashCode() {
 
   @Override
   public Options getDefaultOptions() {
-    return DEFAULT_OPTIONS;
+    return DEFAULT_OPTIONS.copy();
   }
 
   /**

java/core/src/test/org/apache/orc/impl/TestPhysicalFsWriter.java

@@ -26,7 +26,9 @@
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.fs.permission.FsPermission;
 import org.apache.hadoop.util.Progressable;
+import org.apache.orc.CompressionCodec;
 import org.apache.orc.CompressionKind;
+import org.apache.orc.OrcConf;
 import org.apache.orc.OrcFile;
 import org.apache.orc.OrcProto;
 import org.apache.orc.PhysicalWriter;
@@ -330,4 +332,23 @@ public void testShortBlock() throws IOException {
     assertEquals(62 * 1024, dirEntry.getDataLength());
     assertEquals(endOfStripe, shim.lastShortBlock);
   }
+
+  @Test
+  public void testZstdCodec() throws IOException {
+    CompressionCodec zstdCodec = OrcCodecPool.getCodec(CompressionKind.ZSTD);
+    int originalHashCode = zstdCodec.getDefaultOptions().hashCode();
+
+    Configuration conf = new Configuration();
+    conf.setInt(OrcConf.COMPRESSION_ZSTD_LEVEL.getAttribute(), 9);
+    MockHadoopShim shim = new MockHadoopShim();
+    TypeDescription schema = TypeDescription.fromString("int");
+    OrcFile.WriterOptions opts =
+        OrcFile.writerOptions(conf)
+            .compress(CompressionKind.ZSTD)
+            .setSchema(schema)
+            .setShims(shim);
+    MemoryFileSystem fs = new MemoryFileSystem();
+    PhysicalFsWriter writer = new PhysicalFsWriter(fs, new Path("test1.orc"), opts);
+    assertEquals(originalHashCode, zstdCodec.getDefaultOptions().hashCode());
+  }
 }