Skip to content

Commit 340fa8c

Browse files
committed
ORC-1944: Upgrade spotbugs to 4.9.3
### What changes were proposed in this pull request? This PR aims to upgrade `SpotBugs` to 4.9.3. ### Why are the changes needed? To bring the latest improvements like Java 21 support, - https://github.com/spotbugs/spotbugs/releases/tag/4.9.3 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.2 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.1 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.0 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.5 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.4 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.3 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.2 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.1 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.0 - spotbugs/spotbugs#2578 ### How was this patch tested? Manual check the CI logs **BEFORE** - https://github.com/apache/orc/actions/runs/15979589321/job/45070631476 (Java 21) ``` [java] Exception analyzing org.apache.orc.impl.AircompressorCodec$1 using detector edu.umd.cs.findbugs.detect.FindOpenStream [java] org.apache.bcel.classfile.ClassFormatException: Invalid constant pool reference using index: 0. Constant pool size is: 28 [java] At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:305) [java] At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:257) [java] At edu.umd.cs.findbugs.detect.FindOpenStream.visitClassContext(FindOpenStream.java:304) [java] At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76) [java] At edu.umd.cs.findbugs.FindBugs2.lambda$analyzeApplication$1(FindBugs2.java:1108) [java] At java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [java] At edu.umd.cs.findbugs.CurrentThreadExecutorService.execute(CurrentThreadExecutorService.java:86) [java] At java.base/java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:247) [java] At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1118) [java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:309) [java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395) [java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231) ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2306 from dongjoon-hyun/ORC-1944. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4126a7f) Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 28e001b commit 340fa8c

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

java/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@
399399
<dependency>
400400
<groupId>com.github.spotbugs</groupId>
401401
<artifactId>spotbugs</artifactId>
402-
<version>4.7.3</version>
402+
<version>4.9.3</version>
403403
</dependency>
404404
</dependencies>
405405
<executions>

java/spotbugs-exclude.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,10 @@
7474
<Class name="org.apache.orc.tools.ScanData" />
7575
</And>
7676
</Match>
77+
<Match>
78+
<Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE" />
79+
</Match>
80+
<Match>
81+
<Bug pattern="CT_CONSTRUCTOR_THROW" />
82+
</Match>
7783
</FindBugsFilter>

0 commit comments

Comments
 (0)