From bc5b22c9d3a4836d32eb51be25d68b10af1d0dc5 Mon Sep 17 00:00:00 2001 From: Victor Nikulin Date: Thu, 23 Apr 2020 13:06:35 +0200 Subject: [PATCH 1/4] Make ODataEntityCreateRequestImpl constructor public --- .../communication/request/cud/ODataEntityCreateRequestImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java index fbfcefd14e..74e41e2aae 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java @@ -60,7 +60,7 @@ public class ODataEntityCreateRequestImpl * @param targetURI entity set URI. * @param entity entity to be created. */ - ODataEntityCreateRequestImpl(final ODataClient odataClient, final URI targetURI, final E entity) { + public ODataEntityCreateRequestImpl(final ODataClient odataClient, final URI targetURI, final E entity) { super(odataClient, HttpMethod.POST, targetURI); this.entity = entity; } From 0d8776d3b7ce1c23ff0a28bceb9737cee684f396 Mon Sep 17 00:00:00 2001 From: Victor Nikulin Date: Thu, 23 Apr 2020 13:36:49 +0200 Subject: [PATCH 2/4] Make RequestImpl class constructors public --- .../communication/request/cud/ODataDeleteRequestImpl.java | 6 +++--- .../request/cud/ODataEntityCreateRequestImpl.java | 4 ++-- .../request/cud/ODataEntityUpdateRequestImpl.java | 4 ++-- .../request/cud/ODataPropertyUpdateRequestImpl.java | 6 +++--- .../request/cud/ODataReferenceAddingRequestImpl.java | 6 +++--- .../request/cud/ODataValueUpdateRequestImpl.java | 6 +++--- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java index 7ff866e313..ae9714fc02 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java @@ -37,7 +37,7 @@ public class ODataDeleteRequestImpl extends AbstractODataBasicRequest implements ODataDeleteRequest { - ODataDeleteRequestImpl(final ODataClient odataClient, final HttpMethod method, final URI uri) { + public ODataDeleteRequestImpl(final ODataClient odataClient, final HttpMethod method, final URI uri) { super(odataClient, method, uri); } @@ -62,9 +62,9 @@ public ODataDeleteResponse execute() { /** * Response class about an ODataDeleteRequest. */ - private class ODataDeleteResponseImpl extends AbstractODataResponse implements ODataDeleteResponse { + public class ODataDeleteResponseImpl extends AbstractODataResponse implements ODataDeleteResponse { - private ODataDeleteResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + public ODataDeleteResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java index 74e41e2aae..876f4b52c7 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java @@ -94,11 +94,11 @@ public ODataEntityCreateResponse execute() { /** * Response class about an ODataEntityCreateRequest. */ - private class ODataEntityCreateResponseImpl extends AbstractODataResponse implements ODataEntityCreateResponse { + public class ODataEntityCreateResponseImpl extends AbstractODataResponse implements ODataEntityCreateResponse { private E resEntity = null; - private ODataEntityCreateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + public ODataEntityCreateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java index 35b9deca51..8285adefdf 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java @@ -104,14 +104,14 @@ public ODataEntityUpdateResponse execute() { /** * Response class about an ODataEntityUpdateRequest. */ - private class ODataEntityUpdateResponseImpl extends AbstractODataResponse implements ODataEntityUpdateResponse { + public class ODataEntityUpdateResponseImpl extends AbstractODataResponse implements ODataEntityUpdateResponse { /** * Changes. */ private E entity = null; - private ODataEntityUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + public ODataEntityUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java index da889b4faf..6563688d20 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java @@ -58,7 +58,7 @@ public class ODataPropertyUpdateRequestImpl extends AbstractODataBasicRequest reference; - ODataReferenceAddingRequestImpl( + public ODataReferenceAddingRequestImpl( final ODataClient odataClient, final HttpMethod method, final URI uri, final ResWrap reference) { super(odataClient, method, uri); this.reference = reference; @@ -91,9 +91,9 @@ public ODataReferenceAddingResponse execute() { /** * Response class about an ODataReferenceAddingRequest. */ - private class ODataReferenceAddingResponseImpl extends AbstractODataResponse implements ODataReferenceAddingResponse { + public class ODataReferenceAddingResponseImpl extends AbstractODataResponse implements ODataReferenceAddingResponse { - private ODataReferenceAddingResponseImpl( + public ODataReferenceAddingResponseImpl( final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java index 7528184142..9befe39a0b 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java @@ -56,7 +56,7 @@ public class ODataValueUpdateRequestImpl extends AbstractODataBasicRequest Date: Thu, 23 Apr 2020 14:55:39 +0200 Subject: [PATCH 3/4] Make RequestImpl class constructors public --- .../request/cud/ODataEntityCreateRequestImpl.java | 4 ++-- .../request/cud/ODataEntityUpdateRequestImpl.java | 4 ++-- .../request/cud/ODataPropertyUpdateRequestImpl.java | 4 ++-- .../request/cud/ODataReferenceAddingRequestImpl.java | 4 ++-- .../request/cud/ODataValueUpdateRequestImpl.java | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java index 876f4b52c7..74e41e2aae 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityCreateRequestImpl.java @@ -94,11 +94,11 @@ public ODataEntityCreateResponse execute() { /** * Response class about an ODataEntityCreateRequest. */ - public class ODataEntityCreateResponseImpl extends AbstractODataResponse implements ODataEntityCreateResponse { + private class ODataEntityCreateResponseImpl extends AbstractODataResponse implements ODataEntityCreateResponse { private E resEntity = null; - public ODataEntityCreateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + private ODataEntityCreateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java index 8285adefdf..35b9deca51 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java @@ -104,14 +104,14 @@ public ODataEntityUpdateResponse execute() { /** * Response class about an ODataEntityUpdateRequest. */ - public class ODataEntityUpdateResponseImpl extends AbstractODataResponse implements ODataEntityUpdateResponse { + private class ODataEntityUpdateResponseImpl extends AbstractODataResponse implements ODataEntityUpdateResponse { /** * Changes. */ private E entity = null; - public ODataEntityUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + private ODataEntityUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java index 6563688d20..da331c93cb 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java @@ -95,11 +95,11 @@ public InputStream getPayload() { /** * Response class about an ODataPropertyUpdateRequest. */ - public class ODataPropertyUpdateResponseImpl extends AbstractODataResponse implements ODataPropertyUpdateResponse { + private class ODataPropertyUpdateResponseImpl extends AbstractODataResponse implements ODataPropertyUpdateResponse { private ClientProperty resProperty = null; - public ODataPropertyUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + private ODataPropertyUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataReferenceAddingRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataReferenceAddingRequestImpl.java index 28cfcb9dfb..99920cd1cf 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataReferenceAddingRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataReferenceAddingRequestImpl.java @@ -91,9 +91,9 @@ public ODataReferenceAddingResponse execute() { /** * Response class about an ODataReferenceAddingRequest. */ - public class ODataReferenceAddingResponseImpl extends AbstractODataResponse implements ODataReferenceAddingResponse { + private class ODataReferenceAddingResponseImpl extends AbstractODataResponse implements ODataReferenceAddingResponse { - public ODataReferenceAddingResponseImpl( + private ODataReferenceAddingResponseImpl( final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java index 9befe39a0b..678e04fe79 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java @@ -92,11 +92,11 @@ public InputStream getPayload() { /** * Response class about an ODataValueUpdateRequest. */ - public class ODataValueUpdateResponseImpl extends AbstractODataResponse implements ODataValueUpdateResponse { + private class ODataValueUpdateResponseImpl extends AbstractODataResponse implements ODataValueUpdateResponse { private ClientPrimitiveValue resValue = null; - public ODataValueUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + private ODataValueUpdateResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res); From e29c8de02e9dba60714d70efd3f50fd1f74fcbfb Mon Sep 17 00:00:00 2001 From: Victor Nikulin Date: Thu, 23 Apr 2020 14:56:35 +0200 Subject: [PATCH 4/4] Make RequestImpl class constructors public --- .../communication/request/cud/ODataDeleteRequestImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java index ae9714fc02..4f5b3cbd1a 100644 --- a/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java +++ b/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataDeleteRequestImpl.java @@ -62,9 +62,9 @@ public ODataDeleteResponse execute() { /** * Response class about an ODataDeleteRequest. */ - public class ODataDeleteResponseImpl extends AbstractODataResponse implements ODataDeleteResponse { + private class ODataDeleteResponseImpl extends AbstractODataResponse implements ODataDeleteResponse { - public ODataDeleteResponseImpl(final ODataClient odataClient, final HttpClient httpClient, + private ODataDeleteResponseImpl(final ODataClient odataClient, final HttpClient httpClient, final HttpResponse res) { super(odataClient, httpClient, res);