Bring new quantized format inline with old quantized format (#15622)

* Bring new quantized format inline with old quantized format

* iter

Author: benwtrent

lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorScorer.java

@@ -31,7 +31,11 @@
 import org.apache.lucene.util.hnsw.UpdateableRandomVectorScorer;
 import org.apache.lucene.util.quantization.OptimizedScalarQuantizer;
 
-/** Vector scorer over OptimizedScalarQuantized vectors */
+/**
+ * Vector scorer over OptimizedScalarQuantized vectors
+ *
+ * @lucene.experimental
+ */
 public class Lucene104ScalarQuantizedVectorScorer implements FlatVectorsScorer {
   private final FlatVectorsScorer nonQuantizedDelegate;
 
@@ -103,7 +107,7 @@ public RandomVectorScorer getRandomVectorScorer(
     return nonQuantizedDelegate.getRandomVectorScorer(similarityFunction, vectorValues, target);
   }
 
-  RandomVectorScorerSupplier getRandomVectorScorerSupplier(
+  public RandomVectorScorerSupplier getRandomVectorScorerSupplier(
       VectorSimilarityFunction similarityFunction,
       QuantizedByteVectorValues scoringVectors,
       QuantizedByteVectorValues targetVectors) {

lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsFormat.java

@@ -199,7 +199,7 @@ public static ScalarEncoding fromNumBits(int bits) {
       this.queryBitsPerDim = queryBitsPerDim;
     }
 
-    boolean isAsymmetric() {
+    public boolean isAsymmetric() {
       return bits != queryBits;
     }
 

lucene/core/src/java/org/apache/lucene/codecs/lucene104/OffHeapScalarQuantizedVectorValues.java

@@ -133,6 +133,11 @@ public byte[] vectorValue(int targetOrd) throws IOException {
     return vectorValue;
   }
 
+  @Override
+  public IndexInput getSlice() {
+    return slice;
+  }
+
   @Override
   public float getCentroidDP() {
     return centroidDp;
@@ -169,7 +174,7 @@ public float[] getCentroid() {
 
   @Override
   public int getVectorByteLength() {
-    return dimension;
+    return vectorValue.length;
   }
 
   static void packNibbles(byte[] unpacked, byte[] packed) {

lucene/core/src/java/org/apache/lucene/codecs/lucene104/QuantizedByteVectorValues.java

@@ -18,12 +18,14 @@
 
 import java.io.IOException;
 import org.apache.lucene.codecs.lucene104.Lucene104ScalarQuantizedVectorsFormat.ScalarEncoding;
+import org.apache.lucene.codecs.lucene95.HasIndexSlice;
 import org.apache.lucene.index.ByteVectorValues;
 import org.apache.lucene.search.VectorScorer;
+import org.apache.lucene.store.IndexInput;
 import org.apache.lucene.util.quantization.OptimizedScalarQuantizer;
 
 /** Scalar quantized byte vector values */
-abstract class QuantizedByteVectorValues extends ByteVectorValues {
+public abstract class QuantizedByteVectorValues extends ByteVectorValues implements HasIndexSlice {
 
   /**
    * Retrieve the corrective terms for the given vector ordinal. For the dot-product family of
@@ -82,4 +84,9 @@ public abstract OptimizedScalarQuantizer.QuantizationResult getCorrectiveTerms(i
 
   @Override
   public abstract QuantizedByteVectorValues copy() throws IOException;
+
+  @Override
+  public IndexInput getSlice() {
+    return null;
+  }
 }