Add DefaultPooledObjectInfo.pooledObject()

Author: garydgregory

src/main/java/org/apache/commons/pool3/impl/DefaultPooledObjectInfo.java

@@ -101,6 +101,19 @@ private String getTimeMillisFormatted(final long millis) {
         return new SimpleDateFormat(PATTERN).format(Long.valueOf(millis));
     }
 
+    /**
+     * Gets the pooled object for debugging, use at your own risk, changing the state of this object may have unintended consequences for the pool.
+     * <p>
+     * This can't be a traditional getter as that would expose the pooled object via JMX.
+     * </p>
+     *
+     * @return the pooled object for debugging, use at your own risk, changing the state of this object may have unintended consequences for the pool.
+     * @since 2.14.0
+     */
+    public PooledObject<?> pooledObject() {
+        return pooledObject;
+    }
+
     /**
      * @since 2.4.3
      */

src/test/java/org/apache/commons/pool3/impl/TestBaseGenericObjectPool.java

@@ -19,6 +19,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.lang.management.ManagementFactory;
@@ -134,11 +135,13 @@ void testEvictionTimerMultiplePools() throws InterruptedException {
     void testJMXRegistrationLatency() {
         final int numPools = 1000;
         final MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
-        final ArrayList<GenericObjectPool<Waiter, IllegalStateException>> pools = new ArrayList<>();
+        final ArrayList<GenericObjectPool<Waiter, ?>> pools = new ArrayList<>();
         try {
             // final long startTime = System.currentTimeMillis();
             for (int i = 0; i < numPools; i++) {
-                pools.add(new GenericObjectPool<>(new WaiterFactory<>(0, 0, 0, 0, 0, 0), new GenericObjectPoolConfig<>()));
+                final GenericObjectPool<Waiter, ?> gop = new GenericObjectPool<>(new WaiterFactory<>(0, 0, 0, 0, 0, 0), new GenericObjectPoolConfig<>());
+                assertNotNull(gop.getJmxName());
+                pools.add(gop);
             }
             // System.out.println("Duration: " + (System.currentTimeMillis() - startTime));
             final ObjectName oname = pools.get(numPools - 1).getJmxName();

src/test/java/org/apache/commons/pool3/impl/TestDefaultPooledObjectInfo.java

@@ -45,6 +45,17 @@ void testGetLastBorrowTrace() throws Exception {
         }
     }
 
+    @Test
+    void testGetPooledObject() throws Exception {
+        try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory())) {
+            pool.borrowObject();
+            final Set<DefaultPooledObjectInfo> strings = pool.listAllObjects();
+            assertEquals(1, strings.size());
+            final DefaultPooledObjectInfo s1Info = strings.iterator().next();
+            assertEquals("0", s1Info.pooledObject().getObject());
+        }
+    }
+
     @Test
     void testGetPooledObjectToString() throws Exception {
         try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory())) {