kvm: fix/optimize propogating configs (#3911)

Make some changes based on @nvazquez 's comments in PR #3491
Fix a bug in #3491

Author: yadvr

core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java

@@ -319,9 +319,12 @@ private Answer execute(GetDomRVersionCmd cmd) {
     }
 
     public boolean configureHostParams(final Map<String, String> params) {
-        if (_params.get("router.aggregation.command.each.timeout") == null) {
+        if (_params.get("router.aggregation.command.each.timeout") != null) {
             String value = (String)params.get("router.aggregation.command.each.timeout");
-            _eachTimeout = Duration.standardSeconds(NumbersUtil.parseInt(value, 10));
+            _eachTimeout = Duration.standardSeconds(NumbersUtil.parseLong(value, 600));
+            if (s_logger.isDebugEnabled()){
+                s_logger.debug("The router.aggregation.command.each.timeout in seconds is set to " + _eachTimeout.getStandardSeconds());
+            }
         }
 
         return true;

engine/components-api/src/main/java/com/cloud/agent/AgentManager.java

@@ -16,6 +16,8 @@
 // under the License.
 package com.cloud.agent;
 
+import java.util.Map;
+
 import org.apache.cloudstack.framework.config.ConfigKey;
 
 import com.cloud.agent.api.Answer;
@@ -153,5 +155,5 @@ public enum TapAgentsAction {
 
     void notifyMonitorsOfRemovedHost(long hostId, long clusterId);
 
-    void propagateChangeToAgents();
+    void propagateChangeToAgents(Map<String, String> params);
 }

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

@@ -1822,11 +1822,11 @@ private void sendCommandToAgents(Map<Long, List<Long>> hostsPerZone, Map<String,
     }
 
     @Override
-    public void propagateChangeToAgents() {
-        s_logger.debug("Propagating changes on host parameters to the agents");
-        Map<Long, List<Long>> hostsPerZone = getHostsPerZone();
-        Map<String, String> params = new HashMap<String, String>();
-        params.put("router.aggregation.command.each.timeout", _configDao.getValue("router.aggregation.command.each.timeout"));
-        sendCommandToAgents(hostsPerZone, params);
+    public void propagateChangeToAgents(Map<String, String> params) {
+        if (params != null && ! params.isEmpty()) {
+            s_logger.debug("Propagating changes on host parameters to the agents");
+            Map<Long, List<Long>> hostsPerZone = getHostsPerZone();
+            sendCommandToAgents(hostsPerZone, params);
+        }
     }
 }

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

@@ -1106,8 +1106,8 @@ public boolean configureHostParams(final Map<String, String> params) {
         storage.configure("Storage", new HashMap<String, Object>());
         if (params.get("router.aggregation.command.each.timeout") != null) {
             String value = (String)params.get("router.aggregation.command.each.timeout");
-            Integer intValue = NumbersUtil.parseInt(value, 600);
-            storage.persist("router.aggregation.command.each.timeout", String.valueOf(intValue));
+            Long longValue = NumbersUtil.parseLong(value, 600);
+            storage.persist("router.aggregation.command.each.timeout", String.valueOf(longValue));
         }
 
         return true;

server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

@@ -483,7 +483,9 @@ public void onPublishMessage(String serderAddress, String subject, Object args)
                         globalSettingUpdated.equals(IndirectAgentLBServiceImpl.IndirectAgentLBAlgorithm.key())) {
                     _indirectAgentLB.propagateMSListToAgents();
                 } else if (globalSettingUpdated.equals(Config.RouterAggregationCommandEachTimeout.toString())) {
-                    _agentManager.propagateChangeToAgents();
+                    Map<String, String> params = new HashMap<String, String>();
+                    params.put(Config.RouterAggregationCommandEachTimeout.toString(), _configDao.getValue(Config.RouterAggregationCommandEachTimeout.toString()));
+                    _agentManager.propagateChangeToAgents(params);
                 }
             }
         });