PR7877: check if zone has enough capacity in VR deployment (not start)

Author: weizhouapache

server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java

@@ -36,13 +36,15 @@
 import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
 import org.apache.cloudstack.network.router.deployment.RouterDeploymentDefinition;
 import org.apache.cloudstack.utils.CloudStackVersion;
+import org.apache.commons.collections.CollectionUtils;
 import org.apache.log4j.Logger;
 
 import com.cloud.agent.AgentManager;
 import com.cloud.agent.api.Answer;
 import com.cloud.agent.api.to.NicTO;
 import com.cloud.agent.manager.Commands;
 import com.cloud.alert.AlertManager;
+import com.cloud.capacity.CapacityManager;
 import com.cloud.configuration.Config;
 import com.cloud.dc.ClusterVO;
 import com.cloud.dc.DataCenter;
@@ -168,6 +170,8 @@ public class NetworkHelperImpl implements NetworkHelper {
     RouterHealthCheckResultDao _routerHealthCheckResultDao;
     @Inject
     Ipv6Service ipv6Service;
+    @Inject
+    CapacityManager capacityMgr;
 
     protected final Map<HypervisorType, ConfigKey<String>> hypervisorsMap = new HashMap<>();
 
@@ -535,6 +539,10 @@ public DomainRouterVO deployRouter(final RouterDeploymentDefinition routerDeploy
                     }
                 }
 
+                if (!checkIfZoneHasCapacity(routerDeploymentDefinition.getDest().getDataCenter(), hType, routerOffering)) {
+                    continue;
+                }
+
                 router = new DomainRouterVO(id, routerOffering.getId(), routerDeploymentDefinition.getVirtualProvider().getId(), VirtualMachineName.getRouterName(id,
                         s_vmInstanceName), template.getId(), template.getHypervisorType(), template.getGuestOSId(), owner.getDomainId(), owner.getId(),
                         userId, routerDeploymentDefinition.isRedundant(), RedundantState.UNKNOWN, offerHA, false, vpcId);
@@ -577,6 +585,22 @@ public DomainRouterVO deployRouter(final RouterDeploymentDefinition routerDeploy
         return router;
     }
 
+    private boolean checkIfZoneHasCapacity(final DataCenter zone, final HypervisorType hypervisorType, final ServiceOfferingVO routerOffering) {
+        List <HostVO> hosts = _hostDao.listByDataCenterIdAndHypervisorType(zone.getId(), hypervisorType);
+        if (CollectionUtils.isEmpty(hosts)) {
+            s_logger.debug("Zone " + zone + " has no host available which is enabled and in Up state");
+            return false;
+        }
+        for (HostVO host : hosts) {
+            Pair<Boolean, Boolean> cpuCapabilityAndCapacity = capacityMgr.checkIfHostHasCpuCapabilityAndCapacity(host, routerOffering, false);
+            if (cpuCapabilityAndCapacity.first() && cpuCapabilityAndCapacity.second()) {
+                return true;
+            }
+        }
+        s_logger.debug("Zone " + zone + " has no host which has enough capacity");
+        return false;
+    }
+
     protected void filterSupportedHypervisors(final List<HypervisorType> hypervisors) {
         // For non vpc we keep them all assuming all types in the list are
         // supported