[BUGFIX] DOMDocument escapes arrows (#297)

Resolves: #259

Author: simonschaufi

.editorconfig

@@ -17,6 +17,6 @@ indent_style = tab
 indent_size = 2
 
 # XML-Files
-[*.xml]
+[{*.xml,*.xml.fixture}]
 indent_style = tab
 indent_size = 4

packages/fractor-xml/src/XmlFileProcessor.php

@@ -55,6 +55,7 @@ public function handle(File $file, iterable $appliedRules): void
         $iterator->traverseDocument($file, $document);
 
         $newXml = $this->saveXml($document);
+        $newXml = str_replace('->', '->', $newXml);
         $newXml = $this->formatter->format($this->indent, $newXml) . "\n";
 
         if ($newXml === $originalXml) {

packages/fractor-xml/tests/Fixtures/DummyXmlFractorRule.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace a9f\FractorXml\Tests\Fixtures;
+
+use a9f\Typo3Fractor\AbstractFlexformFractor;
+use a9f\Typo3Fractor\Helper\FlexFormHelperTrait;
+use Symfony\Component\DependencyInjection\Exception\BadMethodCallException;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class DummyXmlFractorRule extends AbstractFlexformFractor
+{
+    use FlexFormHelperTrait;
+
+    public function canHandle(\DOMNode $node): bool
+    {
+        return parent::canHandle($node) && $node->nodeName === 'config';
+    }
+
+    public function refactor(\DOMNode $node): \DOMNode|null
+    {
+        if (! $node instanceof \DOMElement) {
+            return null;
+        }
+        $this->removeChildElementFromDomElementByKey($node, 'max');
+        return $node;
+    }
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        throw new BadMethodCallException('Not implemented yet');
+    }
+}

packages/fractor-xml/tests/XmlFileProcessor/Fixtures/fixture.xml.fixture

@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<T3DataStructure>
+	<sheets>
+		<sDEF>
+			<ROOT>
+				<el>
+					<settings.input>
+						<config>
+							<type>input</type>
+							<numIndex>Person->showSelected</numIndex>
+							<max>50</max>
+						</config>
+					</settings.input>
+				</el>
+			</ROOT>
+		</sDEF>
+	</sheets>
+</T3DataStructure>
+-----
+<?xml version="1.0" encoding="UTF-8"?>
+<T3DataStructure>
+	<sheets>
+		<sDEF>
+			<ROOT>
+				<el>
+					<settings.input>
+						<config>
+							<type>input</type>
+							<numIndex>Person->showSelected</numIndex>
+						</config>
+					</settings.input>
+				</el>
+			</ROOT>
+		</sDEF>
+	</sheets>
+</T3DataStructure>

packages/fractor-xml/tests/XmlFileProcessor/XmlFileProcessorTest.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace a9f\FractorXml\Tests\XmlFileProcessor;
+
+use a9f\Fractor\Testing\PHPUnit\AbstractFractorTestCase;
+use a9f\FractorXml\Tests\Fixtures\DummyXmlFractorRule;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+final class XmlFileProcessorTest extends AbstractFractorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+        $this->assertThatRuleIsApplied(DummyXmlFractorRule::class);
+    }
+
+    public static function provideData(): \Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixtures', '*.xml.fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/fractor.php';
+    }
+}

packages/fractor-xml/tests/XmlFileProcessor/config/fractor.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+use a9f\Fractor\Configuration\FractorConfiguration;
+use a9f\Fractor\ValueObject\Indent;
+use a9f\FractorXml\Configuration\XmlProcessorOption;
+use a9f\FractorXml\Tests\Fixtures\DummyXmlFractorRule;
+
+return FractorConfiguration::configure()
+    ->withOptions([
+        XmlProcessorOption::INDENT_CHARACTER => Indent::STYLE_TAB,
+        XmlProcessorOption::INDENT_SIZE => 1,
+    ])
+    ->withRules([DummyXmlFractorRule::class]);