细化 eslint 规则

Author: Linho1219

eslint.config.ts

@@ -23,15 +23,21 @@ export default defineConfigWithVueTs(
 
   {
     rules: {
-      'vue/multi-word-component-names': 'off',
       '@typescript-eslint/no-unused-vars': [
         'warn',
         { argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
       ],
-      '@typescript-eslint/no-namespace': 'off',
       '@typescript-eslint/no-explicit-any': 'off',
+      'vue/multi-word-component-names': 'off',
       'vue/no-mutating-props': 'off',
       'vue/require-v-for-key': 'off',
+      eqeqeq: ['error', 'always'],
+    },
+  },
+  {
+    files: ['**/types.ts'],
+    rules: {
+      '@typescript-eslint/no-namespace': 'off',
     },
   },
 )

pipelines/prosoticDictGen/scripts/csv2dictJson.ts

@@ -1,6 +1,6 @@
 // from SUBTLEXus_syllables-corrected.csv to SUBTLEXus_prosotic.dict.json
-import nlp from 'compromise/tokenize'
 import nlpSpeech from 'compromise-speech'
+import nlp from 'compromise/tokenize'
 import fs from 'fs'
 
 const SRC = './pipelines/prosoticDictGen/SUBTLEXus_syllables-corrected.csv'

src/ui/App.vue

@@ -75,7 +75,7 @@ watch(
   { immediate: true },
 )
 
-const modalDialogActivated = () => !!document.querySelector('.p-dialog-mask.p-overlay-mask')
+const modalDialogActivated = () => document.querySelector('.p-dialog-mask.p-overlay-mask') !== null
 const handleRootKeydown = (e: KeyboardEvent) => {
   const hotkey = parseKeyEvent(e)
   if (!hotkey) return

src/ui/components/CodeMirror.vue

@@ -55,7 +55,7 @@ function highlightCurrentLine() {
       }
       getDeco(view: EditorView) {
         const dropPos = view.state.field(dropCursorPos, false)
-        const pos = dropPos != null ? dropPos : view.state.selection.main.head
+        const pos = typeof dropPos === 'number' ? dropPos : view.state.selection.main.head
         const line = view.state.doc.lineAt(pos)
         currentLine.value = line.number
         return Decoration.set([
@@ -72,15 +72,15 @@ function highlightCurrentLine() {
 // so that fields can be tracked here
 const setDropCursorPos = StateEffect.define<number | null>({
   map(pos, mapping) {
-    return pos == null ? null : mapping.mapPos(pos)
+    return pos === null ? null : mapping.mapPos(pos)
   },
 })
 const dropCursorPos = StateField.define<number | null>({
   create() {
     return null
   },
   update(pos, tr) {
-    if (pos != null) pos = tr.changes.mapPos(pos)
+    if (pos !== null) pos = tr.changes.mapPos(pos)
     return tr.effects.reduce((pos, e) => (e.is(setDropCursorPos) ? e.value : pos), pos)
   },
 })
@@ -104,8 +104,8 @@ const drawDropCursor = ViewPlugin.fromClass(
     }
     update(update: ViewUpdate) {
       const cursorPos = update.state.field(dropCursorPos)
-      if (cursorPos == null) {
-        if (this.cursor != null) {
+      if (cursorPos === null) {
+        if (this.cursor !== null) {
           this.cursor?.remove()
           this.cursor = null
         }
@@ -115,7 +115,7 @@ const drawDropCursor = ViewPlugin.fromClass(
           this.cursor!.className = 'cm-dropCursor'
         }
         if (
-          update.startState.field(dropCursorPos) != cursorPos ||
+          update.startState.field(dropCursorPos) !== cursorPos ||
           update.docChanged ||
           update.geometryChanged
         )
@@ -125,7 +125,7 @@ const drawDropCursor = ViewPlugin.fromClass(
     readPos(): { left: number; top: number; height: number } | null {
       const { view } = this
       const pos = view.state.field(dropCursorPos)
-      const rect = pos != null && view.coordsAtPos(pos)
+      const rect = pos !== null && view.coordsAtPos(pos)
       if (!rect) return null
       const outer = view.scrollDOM.getBoundingClientRect()
       return {
@@ -150,7 +150,7 @@ const drawDropCursor = ViewPlugin.fromClass(
       if (this.cursor) this.cursor.remove()
     }
     setDropPos(pos: number | null) {
-      if (this.view.state.field(dropCursorPos) != pos)
+      if (this.view.state.field(dropCursorPos) !== pos)
         this.view.dispatch({ effects: setDropCursorPos.of(pos) })
     }
   },
@@ -161,7 +161,7 @@ const drawDropCursor = ViewPlugin.fromClass(
       },
       dragleave(event) {
         if (
-          event.target == this.view.contentDOM ||
+          event.target === this.view.contentDOM ||
           !this.view.contentDOM.contains(event.relatedTarget as HTMLElement)
         )
           this.setDropPos(null)
@@ -212,7 +212,7 @@ onMounted(() => {
       highlightCompartment.of([]),
       editableCompartment.of(EditorView.editable.of(!props.readonly)),
       ...(props.extensions || []),
-    ].filter((e) => !!e),
+    ].filter((e) => e !== null),
   })
 })
 onUnmounted(() => {

src/ui/components/HotKeyPopup.vue

@@ -1,6 +1,6 @@
 <template>
   <div class="hotkey-popup">
-    <div class="hotkey-popup-item" v-for="(item, index) in innerList">
+    <div class="hotkey-popup-item" v-for="(_item, index) in innerList">
       <HotKeyInput v-model="innerList[index]!" fluid />
       <Button
         icon="pi pi-times"

src/ui/components/LineOrderInput.vue

@@ -66,7 +66,7 @@ const listItems = ref<ListItem[]>(
     original,
     props.transEnabled ? translation : null,
     props.romanEnabled ? romanization : null,
-  ].filter((i) => !!i),
+  ].filter((i) => i !== null),
 )
 const originalOrder = computed<number | undefined>(() => {
   const index = listItems.value.findIndex((item) => item.key === original.key)

src/utils/alignLineSylTime.ts

@@ -1,7 +1,7 @@
 import type { LyricLine, LyricSyllable } from '@core/types'
 
 const isSyllableTimed = (syl: LyricSyllable) =>
-  !!((syl.startTime || syl.endTime) && syl.text.trim())
+  Boolean((syl.startTime || syl.endTime) && syl.text.trim())
 
 /** Set line's startTime as the startTime of its first syllable */
 export function alignLineStartTime(line: LyricLine) {

src/utils/tryRaf.ts

@@ -6,7 +6,7 @@
  * @param maxAttempts - The maximum number of attempts to execute the callback.
  * @param enableLog - If true, logs each attempt to the console.
  */
-export function tryRaf(callback: () => any, maxAttempts: number = 20, enableLog = false): void {
+export function tryRaf(callback: () => unknown, maxAttempts: number = 20, enableLog = false): void {
   let attempts = 0
   function attempt() {
     if (attempts >= maxAttempts) {