collections.py potential name collision

[jmsv]

This library seems like a cool idea, looking good!

I jumped into the code and noticed there's a file called collections.py, but 'collections' is already a thing in Python:

This might cause namespacey problems, and could slightly hinder readability - I saw collections was being imported in coinhandler.py and briefly thought it was referring to Python's own collections.

Might be worth renaming this to something more specific, although it's not really a problem if you want to keep the name the same

[alxwrd]

Thank you! 🎉

I did know about the built-in collections, but I agree it perhaps isn't the best for readability. 😬

I've got some plans for a move around to allow other coins, e.g.

from coinhandler import CoinHandler
from coinhandler.coins.gbp import *
# or
from coinhandler.coins.jpy import Yen
# or
from coinhandler.coins.usd import *
# or
from coinhandler.coins.fantasy import Gold, Silver, Copper

So I'll probably change it then, but I'm not against a PR to change it in the mean time. 😁

[jmsv]

That looks awesome 😃 I'll keep a look out for new coins