List height fixes

Author: alduris

src/Tabs/EditTab.cs

@@ -40,9 +40,15 @@ public override void Initialize()
             regionSelector = new OpComboBox(OIUtil.CosmeticBind(""),
                 new(SIDE_PADDING, MENU_SIZE - SIDE_PADDING - 30f),
                 TOPBAR_UNIT_WIDTH * 2 + ITEM_GAP,
-                regionList.Select((x, i) => new ListItem(x, $"({x}) {Data.RegionNameFor(x, null)}", i)).ToList());
+                regionList.Select((x, i) => new ListItem(x, $"({x}) {Data.RegionNameFor(x, null)}", i)).ToList())
+            {
+                listHeight = 20
+            };
             regionSelector.OnValueChanged += RegionSelector_OnValueChanged;
-            scugSelector = new OpComboBox(OIUtil.CosmeticBind(""), new(SIDE_PADDING + TOPBAR_UNIT_WIDTH * 2 + ITEM_GAP * 2, regionSelector.pos.y), TOPBAR_UNIT_WIDTH, [""]);
+            scugSelector = new OpComboBox(OIUtil.CosmeticBind(""), new(SIDE_PADDING + TOPBAR_UNIT_WIDTH * 2 + ITEM_GAP * 2, regionSelector.pos.y), TOPBAR_UNIT_WIDTH, [""])
+            {
+                listHeight = 10
+            };
             scugSelector.OnValueChanged += ScugSelector_OnValueChanged;
             var saveButton = new OpSimpleButton(new(MENU_SIZE - SIDE_PADDING - TOPBAR_UNIT_WIDTH, MENU_SIZE - SIDE_PADDING - 30f), new(TOPBAR_UNIT_WIDTH, 24f), "SAVE")
             {
@@ -53,7 +59,10 @@ public override void Initialize()
             // Bottom of menu
             const string IMPORT_TEXT = "Import from: ";
             var importLabel = new OpLabel(SIDE_PADDING, SIDE_PADDING + (12f - LabelTest.LineHeight(false) / 2f), IMPORT_TEXT, false);
-            importSelector = new OpComboBox(OIUtil.CosmeticBind(""), new(importLabel.pos.x + LabelTest.GetWidth(IMPORT_TEXT, false) + 6f, importLabel.pos.y), TOPBAR_UNIT_WIDTH, [""]);
+            importSelector = new OpComboBox(OIUtil.CosmeticBind(""), new(importLabel.pos.x + LabelTest.GetWidth(IMPORT_TEXT, false) + 6f, importLabel.pos.y), TOPBAR_UNIT_WIDTH, [""])
+            {
+                listHeight = 10
+            };
             var importButton = new OpSimpleButton(new(importSelector.pos.x + importSelector.size.x + 6f, importSelector.pos.y), new Vector2(80f, 24f), "IMPORT");
             importButton.OnClick += ImportButton_OnClick;
 

src/Tabs/GenerateTab.cs

@@ -43,7 +43,10 @@ public override void Initialize()
                 allRegions.Add(new ListItem("", ""));
             }
 
-            regionSelector = new OpComboBox(OIUtil.CosmeticBind(""), new Vector2(PADDING, MENU_SIZE - PADDING - BIG_LINE_HEIGHT - MARGIN - 24f), 200f, allRegions);
+            regionSelector = new OpComboBox(OIUtil.CosmeticBind(""), new Vector2(PADDING, MENU_SIZE - PADDING - BIG_LINE_HEIGHT - MARGIN - 24f), 200f, allRegions)
+            {
+                listHeight = 20
+            };
             regionAdd = new OpSimpleButton(new Vector2(regionSelector.pos.x + regionSelector.size.x + MARGIN, regionSelector.pos.y), new Vector2(60f, 24f), "ADD");
             regionAdd.OnClick += RegionAdd_OnClick;
 
@@ -58,12 +61,14 @@ public override void Initialize()
 
             AddItems(
                 new OpShinyLabel(PADDING, MENU_SIZE - PADDING - BIG_LINE_HEIGHT, "GENERATE", true),
-                regionSelector, regionAdd,
                 new OpLabel(PADDING, regionSelector.pos.y - PADDING - BIG_LINE_HEIGHT, "QUEUE", true),
                 queueBox,
                 new OpLabel(PADDING, queueBox.pos.y - PADDING - BIG_LINE_HEIGHT, "CURRENT", true),
                 currentBox,
-                startButton
+                startButton,
+
+                // for z-index ordering reasons
+                regionSelector, regionAdd
             );
         }
 

src/Tabs/ScreenshotTab.cs

@@ -62,7 +62,7 @@ public override void Initialize()
                 .ToList(); // OpComboBox wants it as a list
             comboRegions = new OpComboBox(OIUtil.CosmeticBind(""), new Vector2(10f, 530f), 175f, regionList)
             {
-                listHeight = (ushort)Math.Min(20, RegionNames.Count)
+                listHeight = 20
             };
             var addButton = new OpSimpleButton(new Vector2(195f, 530f), new Vector2(40f, 24f), "ADD");
             var addAllButton = new OpSimpleButton(new Vector2(245f, 530f), new Vector2(40f, 24f), "ALL");