Fix defs a bit

Author: afstanton

config/rails_best_practices.yml

@@ -24,7 +24,7 @@ RemoveEmptyHelpersCheck: { }
 #RemoveTabCheck: { }
 RemoveTrailingWhitespaceCheck: { }
 # RemoveUnusedMethodsInControllersCheck: { except_methods: [] }
-RemoveUnusedMethodsInHelpersCheck: { except_methods: [] }
+# RemoveUnusedMethodsInHelpersCheck: { except_methods: [] }
 # RemoveUnusedMethodsInModelsCheck: { except_methods: [] }
 ReplaceComplexCreationWithFactoryMethodCheck: { attribute_assignment_count: 2 }
 ReplaceInstanceVariableWithLocalVariableCheck: { }

lib/tool_forge/tool_definition.rb

@@ -231,10 +231,10 @@ def to_mcp_tool
           required_params << param_def[:name].to_s if param_def[:required]
         end
 
-        input_schema(
-          properties: properties,
-          required: required_params
-        )
+        schema_args = { properties: properties }
+        schema_args[:required] = required_params if required_params.any?
+        
+        input_schema(**schema_args)
 
         # Create a helper object that contains all the helper methods
         helper_class = Class.new do

lib/tool_forge/version.rb

@@ -2,5 +2,5 @@
 
 module ToolForge
   # The current version of the ToolForge gem
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

spec/spec_helper.rb

@@ -2,8 +2,13 @@
 
 require 'simplecov'
 
-SimpleCov.start do
+SimpleCov.start 'rails' do
+  # NOTE: ViewComponent compiles templates via class_eval; with Ruby 4 + PRISM
+  # and branch coverage for eval, this can segfault. So we disable it here.
+  # enable_coverage_for_eval
+
   enable_coverage :branch
+  primary_coverage :branch
 end
 
 require 'tool_forge'

spec/tool_forge/tool_definition_to_mcp_spec.rb

@@ -47,15 +47,15 @@
     tool_class = tool.to_mcp_tool
     schema = tool_class.input_schema.to_h
 
-    expect(schema[:properties]).to have_key('name')
-    expect(schema[:properties]['name'][:type]).to eq('string')
-    expect(schema[:properties]['name'][:description]).to eq('User name')
+    expect(schema[:properties]).to have_key(:name)
+    expect(schema[:properties][:name][:type]).to eq('string')
+    expect(schema[:properties][:name][:description]).to eq('User name')
 
-    expect(schema[:properties]).to have_key('age')
-    expect(schema[:properties]['age'][:type]).to eq('integer')
-    expect(schema[:properties]['age'][:description]).to eq('User age')
+    expect(schema[:properties]).to have_key(:age)
+    expect(schema[:properties][:age][:type]).to eq('integer')
+    expect(schema[:properties][:age][:description]).to eq('User age')
 
-    expect(schema[:required]).to eq([:name])
+    expect(schema[:required]).to eq(['name'])
   end
 
   it 'creates a call method that executes the block' do
@@ -107,9 +107,9 @@
     tool_class = tool.to_mcp_tool
     schema = tool_class.input_schema.to_h
 
-    expect(schema[:properties]['name'][:type]).to eq('string')
-    expect(schema[:properties]['count'][:type]).to eq('integer')
-    expect(schema[:properties]['active'][:type]).to eq('boolean')
+    expect(schema[:properties][:name][:type]).to eq('string')
+    expect(schema[:properties][:count][:type]).to eq('integer')
+    expect(schema[:properties][:active][:type]).to eq('boolean')
 
     result = tool_class.call(server_context: nil, name: 'test', count: 5, active: true)
     expect(result).to be_a(MCP::Tool::Response)
@@ -128,11 +128,11 @@
     tool_class = tool.to_mcp_tool
     schema = tool_class.input_schema.to_h
 
-    expect(schema[:properties]['str'][:type]).to eq('string')
-    expect(schema[:properties]['int'][:type]).to eq('integer')
-    expect(schema[:properties]['bool'][:type]).to eq('boolean')
-    expect(schema[:properties]['arr'][:type]).to eq('array')
-    expect(schema[:properties]['obj'][:type]).to eq('object')
+    expect(schema[:properties][:str][:type]).to eq('string')
+    expect(schema[:properties][:int][:type]).to eq('integer')
+    expect(schema[:properties][:bool][:type]).to eq('boolean')
+    expect(schema[:properties][:arr][:type]).to eq('array')
+    expect(schema[:properties][:obj][:type]).to eq('object')
   end
 
   describe 'return value formatting' do