Skip to content

Not push info diagnostics for valid cron expressions #269

@minhqdao

Description

@minhqdao

Describe the bug
#224 changed the behavior for valid cron expressions, showing an info diagnostics. It means that even if I have a valid cron expression, a blue squiggly line will always be shown and it will be listed in the PROBLEMS tab of my code editor. My current project doesn't have any analyzer or linter issues, however, it always shows the valid cron expression, which obviously shouldn't be.

That particular part of the PR needs to be reverted or changed and the on-hover info should suffice.

Image Image

To Reproduce
Steps to reproduce the behavior:

  1. Use any valid cron expression, such as
on:
    schedule:
        - cron: "*/30 * * * *"
  1. Observe blue squiggly line and its entry in the PROBLEMS section of VSCode.

Expected behavior
An info on hover, but no blue line and no entry in PROBLEMS (no info diagnostics).

Package/Area

  • Expressions
  • Workflow Parser
  • Language Service
  • Language Server

Package Version
v0.3.28

Additional context
@ericsciple
The Dotcom editor might behave/show info diagnostics differently.
I first reported the issue at the wrong spot: github/vscode-github-actions#539.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions