check if the zauth id is valid

Author: hannes-dev

app/models/user.rb

@@ -37,8 +37,7 @@ class User < ApplicationRecord
   def self.from_omniauth(auth)
     zauth_id = auth.extra.raw_info["id"]
     unless zauth_id.is_a? Integer
-      puts "help"
-      return
+      raise "zauth id is not valid, this is not good, what is happening? what did you do? i am confused and will give up"
     end
 
     db_user = find_by(zauth_id: zauth_id)

spec/models/user_spec.rb

@@ -213,6 +213,23 @@
         expect(user.admin).to be(true)
       end
     end
+
+    describe "when the user has an invalid zauth id" do
+      let(:auth_hash) do
+        OmniAuth::AuthHash.new(
+          {
+            uid: "a-test-user",
+            extra: {
+              raw_info: { roles: ["tap_admin"], id: "7" }
+            }
+          }
+        )
+      end
+
+      it "fails" do
+        expect { described_class.from_omniauth(auth_hash) }.to raise_error("zauth id is not valid, this is not good, what is happening? what did you do? i am confused and will give up")
+      end
+    end
   end
 
   describe "static users" do