Core/Network: Move parsing of EarlyProcessClientPacket from WorldSocket::ReadDataHandlerResult to their handler functions

Author: Shauren

src/server/game/Server/Packets/AuthenticationPackets.cpp

@@ -60,6 +60,11 @@ WorldPacket const* Pong::Write()
     return &_worldPacket;
 }
 
+void LogDisconnect::Read()
+{
+    _worldPacket >> Reason;
+}
+
 WorldPacket const* AuthChallenge::Write()
 {
     _worldPacket.append(DosChallenge.data(), DosChallenge.size());

src/server/game/Server/Packets/AuthenticationPackets.h

@@ -73,6 +73,18 @@ namespace WorldPackets
             uint32 Serial = 0;
         };
 
+        class LogDisconnect final : public EarlyProcessClientPacket<LogDisconnect>
+        {
+        public:
+            explicit LogDisconnect(WorldPacket&& packet) : EarlyProcessClientPacket(CMSG_LOG_DISCONNECT, std::move(packet)) { }
+
+            uint32 Reason = 0;
+
+        private:
+            friend EarlyProcessClientPacket;
+            void Read() override;
+        };
+
         class AuthChallenge final : public ServerPacket
         {
         public:

src/server/game/Server/WorldSession.cpp

@@ -325,9 +325,9 @@ void WorldSession::AddInstanceConnection(WorldSession* session, std::weak_ptr<Wo
 }
 
 /// Add an incoming packet to the queue
-void WorldSession::QueuePacket(WorldPacket* new_packet)
+void WorldSession::QueuePacket(WorldPacket&& new_packet)
 {
-    _recvQueue.add(new_packet);
+    _recvQueue.add(new WorldPacket(std::move(new_packet)));
 }
 
 /// Logging helper for unexpected opcodes

src/server/game/Server/WorldSession.h

@@ -1053,7 +1053,7 @@ class TC_GAME_API WorldSession
         // May kick player on false depending on world config (handler should abort)
         bool DisallowHyperlinksAndMaybeKick(std::string const& str);
 
-        void QueuePacket(WorldPacket* new_packet);
+        void QueuePacket(WorldPacket&& new_packet);
         bool Update(uint32 diff, PacketFilter& updater);
 
         /// Handle the authentication waiting queue (to be completed)