Skip to content

Commit 5a21fe7

Browse files
authored
Merge pull request #172 from Wikidata-lib/cacheFix
Adapt EntitySelector to reworked _cache
2 parents 8932cc2 + 2a7c7ef commit 5a21fe7

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

PropertySuggester.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
return;
1010
}
1111

12-
define( 'PropertySuggester_VERSION', '3.1.1' );
12+
define( 'PropertySuggester_VERSION', '3.1.2' );
1313

1414
if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
1515
require_once __DIR__ . '/vendor/autoload.php';

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ generate this data from a wikidata dump.
4545

4646
## Release notes
4747

48+
### 3.1.2 (2016-08-04)
49+
* Follow up fix for entity suggester, update cache management in EntitySuggester.
50+
4851
### 3.1.1 (2016-08-03)
4952
* Follow up fix for entity suggester, update method call in EntitySuggester.
5053

modules/ext.PropertySuggester.EntitySelector.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,10 @@
5252
search: term,
5353
context: this._getPropertyContext(),
5454
format: 'json',
55-
language: self.options.language,
56-
'continue': self._cache[term] && self._cache[term].nextSuggestionOffset
57-
? self._cache[term].nextSuggestionOffset : 0
55+
language: this.options.language,
56+
'continue': this._cache.term === term && this._cache.nextSuggestionOffset
57+
? this._cache.nextSuggestionOffset
58+
: 0
5859
};
5960
if( data.context == 'item' ) {
6061
data.entity = self._getEntity().getId();

0 commit comments

Comments
 (0)