Skip to content

Commit 1f9ce66

Browse files
Copilotcrramirez
andauthored
Add ICU library dependency to Microsoft Edit installer (#445)
* Initial plan * Add ICU library dependency to Microsoft Edit installer - Install libicu-dev package to provide libicuuc.so for Search/Replace functionality - Add test to verify ICU library installation Co-authored-by: crramirez <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: crramirez <[email protected]>
1 parent ce6d1dd commit 1f9ce66

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

pengwin-setup.d/microsoft-edit.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ readonly EDIT_INSTALL_DEST="/usr/local/bin/edit"
99
function msedit_install() {
1010
if (confirm --title "Microsoft Edit" --yesno "Would you like to download and install Microsoft Edit?" 8 70); then
1111
echo "Installing Microsoft Edit"
12-
install_packages jq zstd
12+
install_packages jq zstd libicu-dev
1313

1414
createtmp
1515

tests/microsoft_edit.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ function test_main() {
99
command -v /usr/local/bin/edit
1010
assertEquals "Microsoft Edit was not installed" "0" "$?"
1111
assertEquals "update-alternatives not configured" "1" "$(run update-alternatives --list editor | grep -c '/usr/local/bin/edit')"
12+
13+
# Verify ICU library is installed for Search and Replace functionality
14+
package_installed libicu-dev
15+
assertTrue "ICU library is not installed" "$?"
1216
}
1317

1418
function test_uninstall() {

0 commit comments

Comments
 (0)