Camel to snake case fix (#36)

Fix camelCase to snake_case parsing

GitOrigin-RevId: 7096178efefdc7b2639c4d21546fee8b35ca3dbf

Author: pszumanski

.gitignore

@@ -5,10 +5,11 @@ target/
 **/.mvn/
 
 ### IntelliJ IDEA ###
-../usos4j-alpha/.idea/
+../usos4j-internal/.idea/
 *.iws
 *.iml
 *.ipr
+.idea
 
 ### Eclipse ###
 .apt_generated

core/src/main/java/pl/wmsdev/usos4j/model/housing/UsosAssignment.java

@@ -1,6 +1,5 @@
 package pl.wmsdev.usos4j.model.housing;
 
-import com.fasterxml.jackson.annotation.JsonAlias;
 import pl.wmsdev.usos4j.model.common.UsosLocalizedString;
 import pl.wmsdev.usos4j.model.common.UsosObject;
 import pl.wmsdev.usos4j.model.user.UsosUser;
@@ -10,8 +9,7 @@
 public record UsosAssignment(String id, UsosUser user, UsosDormitory dormitory,
                              UsosResidentType residentType, UsosDormroomType dormroomType,
                              UsosAllocationPeriod allocationPeriod, Integer numberOfPlaces,
-                             String assignedFrom, String expiryDate, @JsonAlias("can_i_extend") Boolean canIExtend,
-                             @JsonAlias("why_cant_i_extend") UsosLocalizedString whyCantIExtend,
-                             UsosLocalizedString assignedTo,
+                             String assignedFrom, String expiryDate, Boolean canIExtend,
+                             UsosLocalizedString whyCantIExtend, UsosLocalizedString assignedTo,
                              UsosLocalizedString trusteeName, List<UsosResidence> residences) implements UsosObject {
 }

core/src/main/java/pl/wmsdev/usos4j/model/housing/UsosDormitory.java

@@ -1,11 +1,9 @@
 package pl.wmsdev.usos4j.model.housing;
 
-import com.fasterxml.jackson.annotation.JsonAlias;
 import pl.wmsdev.usos4j.model.common.UsosLocalizedString;
 import pl.wmsdev.usos4j.model.common.UsosObject;
 
 import java.util.List;
 
 public record UsosDormitory(String id, UsosLocalizedString name, UsosLocalizedString shortName,
-                            @JsonAlias("can_i_manage") Boolean canIManage,
-                            List<UsosDormroom> dormrooms) implements UsosObject {}
+                            Boolean canIManage, List<UsosDormroom> dormrooms) implements UsosObject {}

core/src/main/java/pl/wmsdev/usos4j/model/surveys/UsosSurveysSurvey2.java

@@ -1,6 +1,5 @@
 package pl.wmsdev.usos4j.model.surveys;
 
-import com.fasterxml.jackson.annotation.JsonAlias;
 import pl.wmsdev.usos4j.model.common.UsosLocalizedString;
 import pl.wmsdev.usos4j.model.common.UsosObject;
 import pl.wmsdev.usos4j.model.fac.UsosFaculty;
@@ -18,17 +17,17 @@ public record UsosSurveysSurvey2(
         String headlineHtml,
         String startDate,
         String endDate,
-        @JsonAlias("can_i_fill_out") Boolean canIFillOut,
-        @JsonAlias("did_i_fill_out") Boolean didIFillOut,
+        Boolean canIFillOut,
+        Boolean didIFillOut,
         UsosGroup group,
         List<UsosGroup> groupsConducted,
         UsosUser lecturer,
         UsosFaculty faculty,
         UsosProgramme programme,
         Integer filledOutCount,
         Integer entitledCount,
-        @JsonAlias("can_i_view_results") Boolean canIViewResults,
-        @JsonAlias("why_cant_i_view_results") UsosLocalizedString whyCantIViewResults,
+        Boolean canIViewResults,
+        UsosLocalizedString whyCantIViewResults,
         List<UsosSurveysQuestion> questions,
         Boolean hasFinalComment
 ) implements UsosObject {

core/src/main/java/pl/wmsdev/usos4j/utils/StringUtils.java

@@ -2,8 +2,20 @@
 
 public final class StringUtils {
 
-    public static String camelToSnakeCase(String text) {
-        return text.replaceAll("([a-z])([A-Z]+)", "$1_$2").toLowerCase();
+    private StringUtils() {
+    }
+
+    public static String camelToSnakeCase(String camelCase) {
+        StringBuilder sb = new StringBuilder();
+
+        for (int i = 0; i < camelCase.length(); i++) {
+            if (Character.isUpperCase(camelCase.charAt(i))) {
+                sb.append('_');
+            }
+            sb.append(Character.toLowerCase(camelCase.charAt(i)));
+        }
+
+        return sb.toString();
     }
 
 }

core/src/test/java/pl/wmsdev/usos4j/unit/StringUtilsTest.java

@@ -0,0 +1,19 @@
+package pl.wmsdev.usos4j.unit;
+
+import org.junit.jupiter.api.Test;
+import pl.wmsdev.usos4j.utils.StringUtils;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class StringUtilsTest {
+
+    @Test
+    void shouldHandleBasicParsing() {
+        assertEquals("exam_session_number", StringUtils.camelToSnakeCase("examSessionNumber"));
+    }
+
+    @Test
+    void shouldHandleSingleLetterWordsParsing() {
+        assertEquals("why_cant_i_view_results", StringUtils.camelToSnakeCase("whyCantIViewResults"));
+    }
+}

integration-tests/src/test/java/pl/wmsdev/UsosRegistrationsAPITest.java

@@ -43,6 +43,7 @@ void facultyTokenRegistrations() {
     }
 
     @Test
+    @Disabled("Registration not active")
     void registration() {
         log(userApi.registrations().registration(UsosRegistrationParams.builder("W04-IST-SI-1-23/24Z").build()));
     }