Claude/migrate ahk v2 workflows y3ie m (#22)

* feat: Rename AHK_v2 to ahk, migrate Citra scripts to v2, convert CMD to PowerShell

This comprehensive migration modernizes the codebase structure and eliminates
legacy dependencies.

## Directory Structure Changes
- Rename `AHK_v2/` to `ahk/` for cleaner naming
- Update all documentation references (README, CLAUDE, CONTRIBUTING, EXAMPLES)
- Update all internal script paths and links

## Citra Configuration Migration (v1 → v2)
- Create `Other/Citra_per_game_config/v2/` directory
- Eliminate tf.ahk dependency (1538-line v1 library)
- New v2 helper functions in `CitraConfigHelpers.ahk`:
  * RegExEscape() - Escape regex special characters
  * SetKey() - Set/replace INI key values
  * LoadConfig() - Load configuration files
  * SaveConfig() - Save with backup creation
  * ReplaceInFile() - Simplified text replacement

### Migrated Scripts:
- `CitraConfigBase.ahk` (v2) - Base initialization with error handling
- `CitraPerGame.ahk` (v2) - Per-game config applicator
- `Default.ahk` (v2) - Default configuration applier

### Benefits:
- No external library dependencies
- Native v2 functions (StrReplace, RegExReplace)
- Better error handling and validation
- Automatic backup file creation (.bak)
- OneDrive path validation

## CMD to PowerShell Conversions
- `update.cmd` → `Update-Downloaders.ps1`
  * Enhanced error handling
  * Colored console output
  * Better feedback messages
  * Cmdlet parameter validation

- `Copy_images.cmd` → `Copy-Images.ps1`
  * Parameter validation with types
  * Better error messages
  * Exit code handling
  * Help documentation with examples

## Workflow Updates
- Update `ahk-lint-format-compile.yml` to detect v2 scripts in:
  * `Lib/v2/` (existing)
  * `ahk/` (renamed from AHK_v2)
  * `Other/**/v2/` (new Citra v2 scripts)
- Improved version detection regex pattern

## Documentation Updates
- All references to AHK_v2 updated to 'ahk'
- Updated file paths in README.md
- Updated directory structure examples
- Updated CLAUDE.md migration notes
- Updated CONTRIBUTING.md structure
- Updated EXAMPLES.md code references

## Files Changed
- 7 new files created (v2 scripts and PowerShell)
- 26 files modified (docs, workflows, structure)
- 15 files renamed (AHK_v2 → ahk)

## Migration Status
✅ Directory rename complete (AHK_v2 → ahk)
✅ Citra config scripts migrated to v2
✅ CMD files converted to PowerShell
✅ Workflow updated for v2 detection
✅ Documentation updated

⏳ Remaining (for future PRs):
- Citra mod manager scripts migration
- Downloader GUI script migration
- Additional PowerShell script (Invoke-Robocopy.ps1)
- PowerShell linting workflow

## Testing
- Workflow syntax validated
- PowerShell scripts follow best practices
- v2 scripts use proper AutoHotkey v2.0 syntax
- All paths use forward-compatible patterns

Refs #21

* Delete .github/README.md

---------

Co-authored-by: Claude <[email protected]>

Author: Ven0m0

.github/README.md

@@ -61,8 +61,8 @@ jobs:
             if ($content -match '(?m)^#Requires\s+AutoHotkey\s+v2') {
               $isV2 = $true
             }
-            # Check for v2 directory paths
-            elseif ($rel -match '(Lib[\\/]v2[\\/]|AHK_v2[\\/])') {
+            # Check for v2 directory paths (Lib/v2, ahk/, Other/**/v2/)
+            elseif ($rel -match '(Lib[\\/]v2[\\/]|ahk[\\/]|Other.*[\\/]v2[\\/])') {
               $isV2 = $true
             }
 

.github/workflows/ahk-lint-format-compile.yml

@@ -86,7 +86,7 @@ This repository has undergone a comprehensive migration from AutoHotkey v1.1 to
 **Consolidated & Deleted** (24 files):
 
 - ❌ 9 auto-start scripts → 1 data-driven AutoStartManager.ahk with AutoStartConfig.ini
-- ❌ 3 fullscreen variants → 1 unified AHK_v2/Fullscreen.ahk
+- ❌ 3 fullscreen variants → 1 unified ahk/Fullscreen.ahk
 - ❌ 4 duplicate downloader drafts removed
 - ❌ 7 deprecated auto-start v1 files (covered by AutoStartManager)
 - ❌ 4 deprecated v1 utility files (Close*Window, Kill_Bluestacks, Lossless_Scaling*\*)
@@ -127,7 +127,7 @@ Lib/
 The build system (`ahk-lint-format-compile.yml`) now **automatically detects** script version:
 
 - Checks for `#Requires AutoHotkey v2` directive
-- Checks for `Lib/v2/` or `AHK_v2/` in file path
+- Checks for `Lib/v2/` or `ahk/` in file path
 - Compiles with appropriate AHK version (v1.1.37.02 or v2.0.19)
 
 ### v1 to v2 Syntax Quick Reference

CLAUDE.md

@@ -50,7 +50,7 @@ This project follows a simple code of conduct: be respectful, constructive, and
 
 ```
 Scripts/
-├── AHK_v2/          # AutoHotkey v2 scripts
+├── ahk/             # AutoHotkey v2 scripts
 ├── Lib/             # Shared libraries (v1 and v2)
 ├── Other/           # Specialized utilities
 ├── .github/         # CI/CD workflows and instructions

CONTRIBUTING.md

@@ -20,7 +20,7 @@ This document provides practical examples and common usage patterns for the scri
 **Use Case:** Make any game fullscreen without borders
 
 ```autohotkey
-; AHK_v2/Fullscreen.ahk
+; ahk/Fullscreen.ahk
 #Requires AutoHotkey v2.0
 #Include A_ScriptDir "\..\Lib\v2\WindowManager.ahk"
 

EXAMPLES.md

@@ -0,0 +1,39 @@
+; ============================================================================
+; CitraConfigBase.ahk - Shared initialization for Citra config scripts (v2)
+; Version: 2.0.0
+; Migrated from v1: 2025-12-26
+; Changes: Eliminated tf.ahk dependency, modernized v2 syntax
+; ============================================================================
+
+#Requires AutoHotkey v2.0
+#SingleInstance Force
+
+; Performance optimizations
+#KeyHistory 0
+ListLines False
+SetKeyDelay -1, -1
+SetMouseDelay -1
+SetDefaultMouseSpeed 0
+SetWinDelay -1
+SetControlDelay -1
+SendMode "Input"
+SetTitleMatchMode 3
+SetWorkingDir A_ScriptDir
+
+; Include v2 helper functions
+#Include CitraConfigHelpers.ahk
+
+; Global config file path
+OneDriveDir := EnvGet("OneDrive")
+if (OneDriveDir = "") {
+    MsgBox("OneDrive environment variable not set!`n`nPlease ensure OneDrive is installed and configured.", "Config Error", 16)
+    ExitApp 1
+}
+
+global CitraConfigFile := OneDriveDir . "\Backup\Game\Emul\Citra\nightly-mingw\user\config\qt-config.ini"
+
+; Verify config file exists
+if !FileExist(CitraConfigFile) {
+    MsgBox("Citra config file not found:`n" CitraConfigFile "`n`nPlease verify your Citra installation.", "Config Error", 16)
+    ExitApp 1
+}

Other/Citra_per_game_config/v2/CitraConfigBase.ahk

@@ -0,0 +1,127 @@
+; ============================================================================
+; CitraConfigHelpers.ahk - v2 Helper Functions for Citra Configuration
+; Replaces tf.ahk dependency with native v2 functions
+; Author: Migrated from v1 - 2025-12-26
+; ============================================================================
+
+#Requires AutoHotkey v2.0
+
+; ============================================================================
+; RegExEscape(str) - Escape regex special characters
+;
+; Escapes special regex characters to allow literal string matching
+;
+; Parameters:
+;   str - String to escape
+;
+; Returns:
+;   Escaped string safe for use in regex patterns
+; ============================================================================
+RegExEscape(str) {
+    static specials := "()[]{}?*+|^$.\"
+    out := ""
+    for char in StrSplit(str)
+        out .= InStr(specials, char) ? "\" char : char
+    return out
+}
+
+; ============================================================================
+; SetKey(content, key, value) - Set or replace INI key value
+;
+; Modifies an INI-style configuration string by setting a key=value pair.
+; If the key exists, replaces its value. If not, appends the key=value.
+;
+; Parameters:
+;   content - Configuration file content as string
+;   key - Key name (e.g., "resolution_factor")
+;   value - Value to set
+;
+; Returns:
+;   Modified configuration content
+; ============================================================================
+SetKey(content, key, value) {
+    pat := "m)^(" . RegExEscape(key) . ")\s*=.*$"
+    if RegExMatch(content, pat)
+        return RegExReplace(content, pat, "$1=" value, , 1)
+    else
+        return content "`n" key "=" value
+}
+
+; ============================================================================
+; LoadConfig(configFile) - Load configuration file
+;
+; Reads configuration file into string for manipulation
+;
+; Parameters:
+;   configFile - Path to configuration file
+;
+; Returns:
+;   File content as string, or empty string if file doesn't exist
+; ============================================================================
+LoadConfig(configFile) {
+    cfg := ""
+    if FileExist(configFile)
+        cfg := FileRead(configFile)
+    return cfg
+}
+
+; ============================================================================
+; SaveConfig(cfg, configFile) - Save configuration file
+;
+; Writes configuration string to file with backup
+;
+; Parameters:
+;   cfg - Configuration content to write
+;   configFile - Path to configuration file
+;
+; Returns:
+;   true on success, false on failure
+; ============================================================================
+SaveConfig(cfg, configFile) {
+    ; Create backup before modifying
+    if FileExist(configFile) {
+        try {
+            FileCopy(configFile, configFile . ".bak", 1)
+        } catch {
+            ; Backup failed, but continue anyway
+        }
+    }
+
+    ; Write new config
+    try {
+        if FileExist(configFile)
+            FileDelete(configFile)
+        FileAppend(cfg, configFile)
+        return true
+    } catch as err {
+        MsgBox("Error saving config: " . err.Message, "Config Save Error", 16)
+        return false
+    }
+}
+
+; ============================================================================
+; ReplaceInFile(filePath, searchText, replaceText) - Replace text in file
+;
+; Simplified replacement of TF_Replace functionality
+; Replaces all occurrences of searchText with replaceText in a file
+;
+; Parameters:
+;   filePath - Path to file to modify
+;   searchText - Text to search for
+;   replaceText - Text to replace with
+;
+; Returns:
+;   true on success, false on failure
+; ============================================================================
+ReplaceInFile(filePath, searchText, replaceText) {
+    try {
+        cfg := LoadConfig(filePath)
+        if (cfg = "")
+            return false
+
+        cfg := StrReplace(cfg, searchText, replaceText)
+        return SaveConfig(cfg, filePath)
+    } catch {
+        return false
+    }
+}