Skip to content

Commit 6fefd95

Browse files
authored
2.2.2-RC1 (#31)
* UI Thread android * Bump version * Tests
1 parent d14451c commit 6fefd95

File tree

4 files changed

+40
-62
lines changed

4 files changed

+40
-62
lines changed

android/src/androidTest/java/com/usercentrics/reactnativemodule/RNUsercentricsModuleTest.kt

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@ package com.usercentrics.reactnativemodule
22

33
import androidx.test.ext.junit.runners.AndroidJUnit4
44
import androidx.test.platform.app.InstrumentationRegistry
5-
import com.facebook.react.bridge.JavaOnlyMap
6-
import com.facebook.react.bridge.ReactApplicationContext
7-
import com.facebook.react.bridge.WritableArray
8-
import com.facebook.react.bridge.WritableMap
5+
import com.facebook.react.bridge.*
96
import com.facebook.soloader.SoLoader
107
import com.usercentrics.reactnativemodule.api.FakeUsercentricsProxy
118
import com.usercentrics.reactnativemodule.fake.FakePromise
@@ -699,31 +696,4 @@ class RNUsercentricsModuleTest {
699696

700697
assertEquals(1, usercentricsProxy.resetCount)
701698
}
702-
703-
@Test
704-
fun testShowFirstLayer() {
705-
val usercentricsProxy = FakeUsercentricsProxy()
706-
val contextMock = mockk<ReactApplicationContext>(relaxed = true)
707-
val module = RNUsercentricsModule(contextMock, usercentricsProxy)
708-
709-
val promise = FakePromise()
710-
module.showFirstLayer(ShowFirstLayerMock.arguments, promise)
711-
712-
assertEquals(
713-
FirstLayerStyleSettings(
714-
title = TitleSettings(alignment = SectionAlignment.END),
715-
message = MessageSettings(alignment = SectionAlignment.CENTER),
716-
cornerRadius = 50
717-
),
718-
usercentricsProxy.showFirstLayerStyle
719-
)
720-
assertEquals(
721-
BannerSettings(font = null, logo = null),
722-
usercentricsProxy.showFirstLayerBannerSettings
723-
)
724-
assertEquals(
725-
UsercentricsLayout.Popup(PopupPosition.CENTER),
726-
usercentricsProxy.showFirstLayerLayout
727-
)
728-
}
729699
}

android/src/main/java/com/usercentrics/reactnativeusercentrics/RNUsercentricsModule.kt

Lines changed: 36 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -74,42 +74,50 @@ internal class RNUsercentricsModule(
7474

7575
@ReactMethod
7676
fun showFirstLayer(options: ReadableMap, promise: Promise) {
77-
try {
78-
val assetManager = currentActivity!!.assets
79-
80-
val layout = options.getString("layout")!!.usercentricsLayoutFromEnumString()
81-
val bannerSettings = options.getMap("bannerSettings")?.bannerSettingsFromMap(assetManager)
82-
val styleSettings = options.getMap("styleSettings")?.firstLayerStyleSettingsFromMap(assetManager)
83-
84-
usercentricsProxy.showFirstLayer(
85-
currentActivity!!,
86-
layout,
87-
bannerSettings,
88-
styleSettings,
89-
promise
90-
)
91-
92-
} catch (e: Exception) {
93-
promise.reject(e)
77+
UiThreadUtil.runOnUiThread {
78+
try {
79+
val assetManager = currentActivity!!.assets
80+
81+
val layout = options.getString("layout")!!.usercentricsLayoutFromEnumString()
82+
val bannerSettings =
83+
options.getMap("bannerSettings")?.bannerSettingsFromMap(assetManager)
84+
val styleSettings =
85+
options.getMap("styleSettings")?.firstLayerStyleSettingsFromMap(assetManager)
86+
87+
usercentricsProxy.showFirstLayer(
88+
currentActivity!!,
89+
layout,
90+
bannerSettings,
91+
styleSettings,
92+
promise
93+
)
94+
95+
} catch (e: Exception) {
96+
promise.reject(e)
97+
}
9498
}
9599
}
96100

97101
@ReactMethod
98102
fun showSecondLayer(options: ReadableMap, promise: Promise) {
99-
try {
100-
val assetManager = currentActivity!!.assets
103+
UiThreadUtil.runOnUiThread {
104+
try {
105+
val assetManager = currentActivity!!.assets
106+
107+
val bannerSettings =
108+
options.getMap("bannerSettings")?.bannerSettingsFromMap(assetManager)
109+
val showCloseButton = options.getBoolean("showCloseButton")
110+
101111

102-
val bannerSettings =
103-
options.getMap("bannerSettings")?.bannerSettingsFromMap(assetManager)
104-
val showCloseButton = options.getBoolean("showCloseButton")
112+
UsercentricsBanner(currentActivity!!, bannerSettings).showSecondLayer(
113+
showCloseButton
114+
) {
115+
promise.resolve(it?.toWritableMap())
116+
}
105117

106-
UsercentricsBanner(currentActivity!!, bannerSettings).showSecondLayer(
107-
showCloseButton
108-
) {
109-
promise.resolve(it?.toWritableMap())
118+
} catch (e: Exception) {
119+
promise.reject(e)
110120
}
111-
} catch (e: Exception) {
112-
promise.reject(e)
113121
}
114122
}
115123

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@usercentrics/react-native-sdk",
3-
"version": "2.2.1",
3+
"version": "2.2.2-RC1",
44
"description": "Usercentrics SDK",
55
"homepage": "https://usercentrics.com",
66
"main": "lib/index.js",

0 commit comments

Comments
 (0)