TypeError: client.shell is not a function @u4/adbkit

[tiennguyen12g]

Hello everyone, i get this error : "TypeError: client.shell is not a function". Here is my node server:
const express = require('express');
const { Readable } = require('stream');
const Adb = require('@u4/adbkit');

const app = express();
const client = Adb.createClient();

app.get("/",(req, res) => {
res.sendFile(__dirname + "/test.html");
});

app.get('/video', async (req, res) => {
const stream = client.shell('scrcpy -s R9HT10HL56R --no-display', 'device');
Adb.Utils.readAll(stream).then(output => {
const readable = new Readable();
readable.push(output);
readable.push(null);
res.set('Content-Type', 'video/mp4');
readable.pipe(res);
}).catch(err => {
console.error(err);
res.status(500).send('Error streaming video');
});
});
app.listen(3000, () => {
console.log('Server listening on port 8000');
});

If you have faced with this issue, please give a solution. Thank you.

[xTheEc0]

shell function is under DeviceClient not Client
https://urielch.github.io/adbkit/classes/DeviceClient.html#shell
So instead of using client.shell(command, deviceID), it is device.shell(command).

(also, note, wasn't the old function client.shell(deviceID, command) not the other way around?)

I will also post some code from my own repo, on how I use it, maybe that will help you build : )

[xTheEc0]

Here is a snippet from my project
This is only a small part, didn't want to make a very big message, but I also have functions like:
GetIMEI();
GetGPUProperties();
GetMACAddress();
etc

I also added some comments, hope they help : )

import { Adb } from '@u4/adbkit';
import fs from 'fs';
import Path from 'path';
import { fileURLToPath } from 'url';

const __filename = fileURLToPath(import.meta.url);
const __dirname = Path.dirname(__filename);
const PATH = Path.resolve(__dirname, '../', 'resources');

const client = Adb.createClient();

const GetAllConnectedDevices = async () => {
    const devices = await client.listDevices();
    // This returns just device serial ID's, so we have to convert them into DeviceClient objects
    // (otherwise they won't have functions like `.shell()` etc;

    const out = [];
    for (const d of devices) {
        const device = client.getDevice(d.id);
        // getDevice returns DeviceClient. Now we can use these objects
        out.push(device);
    }
    return out;
};

const InstallAIDA = async (devices) => {
    // prep aida path and install options
    const apk = Path.join(PATH, 'aida64-v191.apk');
    const options = {
        wait: false,
        action: '-n',
        component: 'com.finalwire.aida64/com.finalwire.aida64.HHMainActivity',
    };

    // go through each connected device, check if it has aida installed, if not - install it, and launch it.
    for (const device of devices) {
        const isInstalled = await device.isInstalled('com.finalwire.aida64');
        if (!isInstalled) {
            await device.install(apk);
        }
        await device.startActivity(options);
    }
    return devices;
};

const GenerateDevices = async () => {
    let devices = await GetAllConnectedDevices();
    devices = await InstallAIDA(devices);
 
    return devices;
};

[UrielCh]

If you correctly use the typing, you should get this kind of error directly in your IDE.

Of course if you are using the lib in a Typescript project, be sure you will not get such an error.

[tiennguyen12g]

Thank @UrielCh @xTheEc0 . Hihi

[tiennguyen12g]

shell function is under DeviceClient not Client https://urielch.github.io/adbkit/classes/DeviceClient.html#shell So instead of using client.shell(command, deviceID), it is device.shell(command).

(also, note, wasn't the old function client.shell(deviceID, command) not the other way around?)

I will also post some code from my own repo, on how I use it, maybe that will help you build : )

hello my friend, do you have code to get client.framebuffer() ?

[xTheEc0]

I've never used it, but it looks well documented
https://urielch.github.io/adbkit/classes/DeviceClient.html#framebuffer

[tiennguyen12g]

I've never used it, but it looks well documented https://urielch.github.io/adbkit/classes/DeviceClient.html#framebuffer
<

Thank you.
Do you have code to get the frame video data that use to display android device on Pc?