feature: add logs for executeExtrinsic & error handling, skip AppPromo tests for update case

Author: PraetorP

.github/workflows/main-process-update.yml

@@ -283,6 +283,7 @@ jobs:
           NOW=$(date +%s) && deno task testSubParallel
         env:
           RPC_URL: ${{ env.RELAY_UNIQUE_HTTP_URL }}
+          SKIP_APP_PROMO_TESTS: 1
 
       - name: Run Sequential Substrate tests after upgrade
         working-directory: js-packages/tests
@@ -291,6 +292,7 @@ jobs:
           NOW=$(date +%s) && deno task testSubSequential
         env:
           RPC_URL: ${{ env.RELAY_UNIQUE_HTTP_URL }}
+          SKIP_APP_PROMO_TESTS: 1
 
       - name: Run Parallel Ethereum tests after upgrade
         working-directory: js-packages/tests

js-packages/playgrounds/unique.ts

@@ -775,7 +775,9 @@ export class ChainHelperBase {
     }
     catch (e) {
       if(!Object.hasOwn(e as object, 'status')) throw e;
+      console.log(`[ExecuteExtrinsic] Caught error during extrinsic: (${extrinsic})...`); 
       result = e as ITransactionResult;
+      if (result == null) throw e;
     }
 
     const endTime = (new Date()).getTime();

js-packages/test-utils/util.ts

@@ -154,6 +154,7 @@ export type FixedDescribe = {
   skip: (...args: DescribeArgs<UniqueTestContext>) => void;
   ifRunGov: (...args: DescribeArgs<UniqueTestContext>) => TestSuite<UniqueTestContext>;
   ifRunXcm: (...args: DescribeArgs<UniqueTestContext>) => TestSuite<UniqueTestContext>;
+  ifRunAppPromo: (...args: DescribeArgs<UniqueTestContext>) => TestSuite<UniqueTestContext>;
   ifRunOcw: (...args: DescribeArgs<UniqueTestContext>) => TestSuite<UniqueTestContext>;
   ifRunCollators: (...args: DescribeArgs<UniqueTestContext>) => TestSuite<UniqueTestContext>;
 };
@@ -175,6 +176,11 @@ export const describe: FixedDescribe = Object.assign(
         ? describeBdd<UniqueTestContext>(...args)
         : describeBdd.skip<UniqueTestContext>(...args);
     },
+    ifRunAppPromo: (...args: DescribeArgs<UniqueTestContext>) => {
+      return process.env.SKIP_APP_PROMO_TESTS
+        ? describeBdd.skip<UniqueTestContext>(...args)
+        : describeBdd<UniqueTestContext>(...args);
+    },
     ifRunOcw: (...args: DescribeArgs<UniqueTestContext>) => {
       return process.env.RUN_OCW_TESTS
         ? describeBdd<UniqueTestContext>(...args)

js-packages/tests/sub/appPromotion/appPromotion.seqtest.ts

@@ -22,7 +22,7 @@ let superuser: IKeyringPair;
 let donor: IKeyringPair;
 let palletAdmin: IKeyringPair;
 
-describe('App promotion', () => {
+describe.ifRunAppPromo('App promotion', () => {
   before(async function () {
     await usingPlaygrounds(async (helper, privateKey) => {
       requirePalletsOrSkip(helper, [Pallets.AppPromotion]);

js-packages/tests/sub/appPromotion/appPromotion.test.ts

@@ -47,7 +47,7 @@ async function getAccounts(accountsNumber: number, balance?: bigint) {
 // LOCKING_PERIOD = 12 blocks of relay
 // UNLOCKING_PERIOD = 12 blocks of parachain
 
-describe('App promotion', () => {
+describe.ifRunAppPromo('App promotion', () => {
   before(async function () {
     await usingPlaygrounds(async (helper, privateKey) => {
       requirePalletsOrSkip(helper, [Pallets.AppPromotion]);