Skip to content

Commit f35ffb2

Browse files
Suppress warnings if no files are found, update dataRetrieval url
1 parent 3d3d2ef commit f35ffb2

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

.github/workflows/test-coverage.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,4 @@ jobs:
4848
with:
4949
name: coverage-test-failures
5050
path: ${{ runner.temp }}/package
51+
if-no-files-found: ignore # Suppress warnings if no files are found
Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,26 @@
11
test_that("No NA's in dependent flag columns", {
22
today <- Sys.Date()
33
twoago <- as.character(today - 2 * 365)
4-
testdat <- TADA_DataRetrieval(statecode = "UT", startDate = twoago, characteristicName = c("Nitrate", "Copper"), sampleMedia = "Water", ask = FALSE)
5-
testdat <- TADA_ConvertResultUnits(testdat, transform = TRUE)
4+
testdat <- TADA_DataRetrieval(statecode = "UT",
5+
startDate = twoago,
6+
characteristicName = c("Nitrate", "Copper"),
7+
sampleMedia = "Water",
8+
ask = FALSE)
9+
testdat <- TADA_ConvertResultUnits(testdat,
10+
transform = TRUE)
611

7-
testdat <- suppressWarnings(TADA_FlagFraction(testdat, clean = FALSE, flaggedonly = FALSE))
12+
testdat <- suppressWarnings(TADA_FlagFraction(testdat,
13+
clean = FALSE,
14+
flaggedonly = FALSE))
815
expect_false(any(is.na(testdat$TADA.SampleFraction.Flag)))
916

10-
testdat <- suppressWarnings(TADA_FlagSpeciation(testdat, clean = "none", flaggedonly = FALSE))
17+
testdat <- suppressWarnings(TADA_FlagSpeciation(testdat,
18+
clean = "none",
19+
flaggedonly = FALSE))
1120
expect_false(any(is.na(testdat$TADA.MethodSpeciation.Flag)))
1221

13-
testdat <- suppressWarnings(TADA_FlagResultUnit(testdat, clean = "none", flaggedonly = FALSE))
22+
testdat <- suppressWarnings(TADA_FlagResultUnit(testdat,
23+
clean = "none",
24+
flaggedonly = FALSE))
1425
expect_false(any(is.na(testdat$TADA.ResultUnit.Flag)))
1526
})

vignettes/TADAModule1.Rmd

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,7 @@ Additional resources:
197197
the console: ?TADA_DataRetrieval
198198

199199
- [Introduction to the dataRetrieval
200-
package](https://CRAN.R-project.org/package=dataRetrieval)
201-
202-
- [General Data Import from Water Quality
203-
Portal](https://rdrr.io/cran/dataRetrieval/man/readWQPdata.html)
200+
package](https://doi-usgs.github.io/dataRetrieval/)
204201

205202
- [Water Quality Portal Web Services
206203
Guide](https://www.waterqualitydata.us/webservices_documentation/)

0 commit comments

Comments
 (0)