Webhook Changes (#54)

* Change to 204 response

* Use typescript in-constructor properties

* Build docs

Author: jpbberry

docs/Api.md

@@ -38,7 +38,7 @@ const api = new Topgg.Api('Your top.gg token')
 <a name="Api+postStats"></a>
 
 ### api.postStats(stats) ⇒ <code>BotStats</code>
-Post bot stats to Top.gg (Do not use if you supplied a client)
+Post bot stats to Top.gg
 
 **Kind**: instance method of [<code>Api</code>](#Api)  
 **Returns**: <code>BotStats</code> - Passed object  

src/structs/Webhook.ts

@@ -24,15 +24,11 @@ import { WebhookPayload } from '../typings'
  * // Authorization: webhookauth123
  */
 export class Webhook {
-  private auth: string
-
   /**
    * Create a new webhook client instance
    * @param authorization Webhook authorization to verify requests
    */
-  constructor (authorization?: string) {
-    this.auth = authorization
-  }
+  constructor (private authorization?: string) {}
 
   private _formatIncoming (body): WebhookPayload {
     if (body?.query?.length > 0) body.query = qs.parse(body.query.substr(1))
@@ -41,7 +37,7 @@ export class Webhook {
 
   private _parseRequest (req, res): Promise<WebhookPayload|false> {
     return new Promise(resolve => {
-      if (this.auth && req.headers.authorization !== this.auth) return res.status(403).json({ error: 'Unauthorized' })
+      if (this.authorization && req.headers.authorization !== this.authorization) return res.status(403).json({ error: 'Unauthorized' })
       // parse json
 
       if (req.body) return resolve(this._formatIncoming(req.body))
@@ -72,7 +68,7 @@ export class Webhook {
     return async (req, res, next) => {
       const response = await this._parseRequest(req, res)
       if (!response) return
-      res.sendStatus(200)
+      res.sendStatus(204)
       req.vote = response
       next()
     }