feat: implement auto-close for PRs with negative reviews (#309)

TooAngel · web-flow · commit 2e7a9e32925b · 2025-11-07T16:52:12.000Z
Add symmetric auto-close functionality to complement auto-merge:
- PRs with negative coefficient (&lt; 0) now auto-close after extended period
- Close duration: (1 + coefficient) × baseCloseTimeInHours (default: 100 days)
- Timer resets on commits, just like merge path
- 10x more forgiving than merge (100 vs 10 days default)

Configuration:
- New baseCloseTimeInHours config option (default: 2400 hours = 100 days)
- Configurable via .worlddriven.ini per repository

Implementation:
- Updated time calculation logic to handle both merge and close paths
- Added closePullRequest() API function with hybrid auth support
- GitHub status shows "Close at YYYY-MM-DD" for negative coefficients
- Processor now handles close action alongside merge action

Examples:
- Coefficient 0: merge at 10 days (unchanged)
- Coefficient -0.5: close at 50 days
- Coefficient -1.0: close immediately

Addresses stale PR cleanup while maintaining democratic rejection consensus.
diff --git a/src/helpers/config.js b/src/helpers/config.js
@@ -58,6 +58,7 @@ export function parseIniFile(content) {
 export async function fetchRepositoryConfig(githubClient, owner, repo) {
   const defaultConfig = {
     baseMergeTimeInHours: 240,
+    baseCloseTimeInHours: 2400,
     perCommitTimeInHours: 0,
     merge_method: 'squash',
   };
@@ -121,6 +122,13 @@ export async function fetchRepositoryConfig(githubClient, owner, repo) {
       }
     }
 
+    if (defaultSection.baseCloseTimeInHours) {
+      const value = parseFloat(defaultSection.baseCloseTimeInHours);
+      if (!isNaN(value) && value >= 0) {
+        config.baseCloseTimeInHours = value;
+      }
+    }
+
     if (defaultSection.merge_method) {
       const method = defaultSection.merge_method.toLowerCase();
       if (['merge', 'squash', 'rebase'].includes(method)) {
diff --git a/src/helpers/github.js b/src/helpers/github.js
@@ -2,6 +2,7 @@
 import {
   getPullRequestsApp,
   mergePullRequestApp,
+  closePullRequestApp,
   setCommitStatusApp,
   getLatestCommitShaApp,
   createIssueCommentApp,
@@ -128,6 +129,62 @@ export async function mergePullRequest(
   }
 }
 
+/**
+ * closePullRequest - Hybrid authentication (GitHub App or PAT)
+ *
+ * @param {object|number} userOrInstallationId - User object with githubAccessToken or installationId number
+ * @param {string} owner
+ * @param {string} repo
+ * @param {number} number
+ * @return {void}
+ */
+export async function closePullRequest(
+  userOrInstallationId,
+  owner,
+  repo,
+  number
+) {
+  // If it's a number, treat as installationId (GitHub App)
+  if (
+    typeof userOrInstallationId === 'number' ||
+    (typeof userOrInstallationId === 'string' && !isNaN(userOrInstallationId))
+  ) {
+    return await closePullRequestApp(
+      parseInt(userOrInstallationId),
+      owner,
+      repo,
+      number
+    );
+  }
+
+  // Otherwise, use existing PAT logic
+  const user = userOrInstallationId;
+  const url = `https://api.github.com/repos/${owner}/${repo}/pulls/${number}`;
+
+  try {
+    const response = await fetch(url, {
+      method: 'PATCH',
+      headers: {
+        Accept: 'application/vnd.github.v3+json',
+        Authorization: `token ${user.githubAccessToken}`,
+        'Content-Type': 'application/json',
+      },
+      body: JSON.stringify({
+        state: 'closed',
+      }),
+    });
+
+    if (!response.ok) {
+      throw new Error(`HTTP ${response.status}: ${response.statusText}`);
+    }
+
+    return response;
+  } catch (e) {
+    console.log(e);
+    return;
+  }
+}
+
 /**
  * createIssueComment - Hybrid authentication (GitHub App or PAT)
  *
diff --git a/src/helpers/githubApp.js b/src/helpers/githubApp.js
@@ -59,6 +59,24 @@ export async function mergePullRequestApp(
   }
 }
 
+export async function closePullRequestApp(installationId, owner, repo, number) {
+  const octokit = await getInstallationOctokit(installationId);
+  try {
+    return await octokit.rest.pulls.update({
+      owner,
+      repo,
+      pull_number: number,
+      state: 'closed',
+    });
+  } catch (error) {
+    console.error(
+      `Failed to close PR ${owner}/${repo}#${number}:`,
+      error.message
+    );
+    throw error;
+  }
+}
+
 export async function setCommitStatusApp(
   installationId,
   owner,
diff --git a/src/helpers/pullRequest.js b/src/helpers/pullRequest.js
@@ -128,7 +128,7 @@ function processReviews(contributors, reviews, pull) {
 }
 
 /**
- * Calculate time-based metrics for pull request merging
+ * Calculate time-based metrics for pull request merging or closing
  *
  * @param {Array} contributors - Array of contributor objects
  * @param {object} dates - Date metrics object
@@ -140,32 +140,57 @@ function processReviews(contributors, reviews, pull) {
 function calculateTimeMetrics(contributors, dates, pull, coefficient, config) {
   const age = (new Date().getTime() - dates.max) / 1000;
 
-  const totalMergeTime =
-    (config.baseMergeTimeInHours / 24 +
-      (pull.commits * config.perCommitTimeInHours) / 24) *
-    24 *
-    60 *
-    60;
-
-  const mergeDuration = (1 - coefficient) * totalMergeTime;
-  const daysToMerge = mergeDuration - age;
-
-  // Calculate individual contributor time values
+  // Calculate individual contributor time values (for merge path)
   const votesTotal = contributors.reduce((total, current) => {
     return total + current.commits;
   }, 0);
 
-  for (const contributor of contributors) {
-    contributor.timeValue = (contributor.commits / votesTotal) * totalMergeTime;
-  }
+  if (coefficient >= 0) {
+    // MERGE PATH: Positive or neutral coefficient
+    const totalMergeTime =
+      (config.baseMergeTimeInHours / 24 +
+        (pull.commits * config.perCommitTimeInHours) / 24) *
+      24 *
+      60 *
+      60;
 
-  return {
-    age,
-    daysToMerge,
-    mergeDuration,
-    totalMergeTime,
-    mergeDate: (new Date(dates.max).getTime() + mergeDuration * 1000) / 1000,
-  };
+    const mergeDuration = (1 - coefficient) * totalMergeTime;
+    const daysToMerge = mergeDuration - age;
+
+    for (const contributor of contributors) {
+      contributor.timeValue =
+        (contributor.commits / votesTotal) * totalMergeTime;
+    }
+
+    return {
+      action: 'merge',
+      age,
+      daysToMerge,
+      mergeDuration,
+      totalMergeTime,
+      mergeDate: (new Date(dates.max).getTime() + mergeDuration * 1000) / 1000,
+    };
+  } else {
+    // CLOSE PATH: Negative coefficient
+    const totalCloseTime = (config.baseCloseTimeInHours / 24) * 24 * 60 * 60;
+
+    const closeDuration = (1 + coefficient) * totalCloseTime;
+    const daysToClose = closeDuration - age;
+
+    // Set contributor time values to 0 for close path (not applicable)
+    for (const contributor of contributors) {
+      contributor.timeValue = 0;
+    }
+
+    return {
+      action: 'close',
+      age,
+      daysToClose,
+      closeDuration,
+      totalCloseTime,
+      closeDate: (new Date(dates.max).getTime() + closeDuration * 1000) / 1000,
+    };
+  }
 }
 
 /**
@@ -231,12 +256,7 @@ export async function getPullRequestData(githubClient, owner, repo, number) {
       coefficient: coefficient,
     },
     dates: dates,
-    times: {
-      daysToMerge: timeMetrics.daysToMerge,
-      mergeDuration: timeMetrics.mergeDuration,
-      totalMergeTime: timeMetrics.totalMergeTime,
-      mergeDate: timeMetrics.mergeDate,
-    },
+    times: timeMetrics,
   };
 
   return pullRequestData;
diff --git a/src/helpers/pullRequestProcessor.js b/src/helpers/pullRequestProcessor.js
@@ -1,6 +1,7 @@
 import { getPullRequestData } from './pullRequest.js';
 import {
   mergePullRequest,
+  closePullRequest,
   setCommitStatus,
   getLatestCommitSha,
 } from './github.js';
@@ -31,13 +32,14 @@ async function setPullRequestStatus(
 
     let state, description;
 
-    if (coefficient >= 0) {
+    if (pullRequestData.times.action === 'merge') {
       const mergeDate = new Date(pullRequestData.times.mergeDate * 1000);
       state = 'success';
       description = `${coefficient.toFixed(2)} Merge at ${mergeDate.toISOString().split('T')[0]}`;
-    } else {
+    } else if (pullRequestData.times.action === 'close') {
+      const closeDate = new Date(pullRequestData.times.closeDate * 1000);
       state = 'error';
-      description = `${coefficient.toFixed(2)} Will not merge`;
+      description = `${coefficient.toFixed(2)} Close at ${closeDate.toISOString().split('T')[0]}`;
     }
 
     await setCommitStatus(
@@ -140,8 +142,14 @@ export async function processPullRequests() {
               pullRequest.number
             );
 
-            prResult.daysToMerge = pullRequestData.times.daysToMerge;
-            console.log(`Days to merge: ${pullRequestData.times.daysToMerge}`);
+            prResult.daysToMerge = pullRequestData.times.daysToMerge || null;
+            prResult.daysToClose = pullRequestData.times.daysToClose || null;
+            const actionDays =
+              pullRequestData.times.daysToMerge ||
+              pullRequestData.times.daysToClose;
+            console.log(
+              `Days to ${pullRequestData.times.action}: ${actionDays}`
+            );
 
             // Set GitHub status for this pull request
             await setPullRequestStatus(
@@ -152,7 +160,10 @@ export async function processPullRequests() {
               pullRequestData
             );
 
-            if (pullRequestData.times.daysToMerge < 0) {
+            if (
+              pullRequestData.times.action === 'merge' &&
+              pullRequestData.times.daysToMerge < 0
+            ) {
               console.log(
                 `⚡ Merging ${repository.owner}/${repository.repo} - ${pullRequestData.title} using ${pullRequestData.config.merge_method} method`
               );
@@ -181,15 +192,47 @@ export async function processPullRequests() {
                 console.log('❌ Cannot merge PR');
                 prResult.action = 'merge_failed';
               }
+            } else if (
+              pullRequestData.times.action === 'close' &&
+              pullRequestData.times.daysToClose < 0
+            ) {
+              console.log(
+                `🗑️  Closing ${repository.owner}/${repository.repo} - ${pullRequestData.title} due to negative feedback`
+              );
+
+              const closeResponse = await closePullRequest(
+                authMethod,
+                repository.owner,
+                repository.repo,
+                pullRequest.number
+              );
+
+              if (closeResponse) {
+                await updateOrCreateWorlddrivenComment(
+                  authMethod,
+                  repository.owner,
+                  repository.repo,
+                  pullRequest.number,
+                  pullRequestData,
+                  'Pull request closed by worlddriven ❌'
+                );
+                console.log('✅ Closed successfully');
+                prResult.action = 'closed';
+              } else {
+                console.log('❌ Cannot close PR');
+                prResult.action = 'close_failed';
+              }
             } else {
               const daysRemaining = Math.ceil(
-                pullRequestData.times.daysToMerge / 86400
+                (pullRequestData.times.daysToMerge ||
+                  pullRequestData.times.daysToClose) / 86400
               );
+              const action = pullRequestData.times.action;
               console.log(
-                `⏳ PR not ready for merge (${daysRemaining} days remaining)`
+                `⏳ PR not ready for ${action} (${daysRemaining} days remaining)`
               );
 
-              // Update comment to refresh merge countdown without adding activity log entry
+              // Update comment to refresh countdown without adding activity log entry
               await updateOrCreateWorlddrivenComment(
                 authMethod,
                 repository.owner,
diff --git a/tests/calculation-core.test.js b/tests/calculation-core.test.js
